Support DROP [TABLE|VIEW]

Co-authored-by: Jamie Brandon <[email protected]>

Author: benesch

src/dialect/keywords.rs

@@ -71,6 +71,7 @@ define_keywords!(
     CALL,
     CALLED,
     CARDINALITY,
+    CASCADE,
     CASCADED,
     CASE,
     CAST,
@@ -178,6 +179,7 @@ define_keywords!(
     HOLD,
     HOUR,
     IDENTITY,
+    IF,
     IN,
     INDICATOR,
     INNER,
@@ -290,6 +292,7 @@ define_keywords!(
     REGR_SXY,
     REGR_SYY,
     RELEASE,
+    RESTRICT,
     RESULT,
     RETURN,
     RETURNS,

src/sqlast/mod.rs

@@ -394,6 +394,10 @@ pub enum SQLStatement {
         name: SQLObjectName,
         operation: AlterOperation,
     },
+    /// DROP TABLE
+    SQLDropTable(SQLDrop),
+    /// DROP VIEW
+    SQLDropView(SQLDrop),
 }
 
 impl ToString for SQLStatement {
@@ -499,6 +503,8 @@ impl ToString for SQLStatement {
                 name.to_string(),
                 comma_separated_string(columns)
             ),
+            SQLStatement::SQLDropTable(drop) => drop.to_string_internal("TABLE"),
+            SQLStatement::SQLDropView(drop) => drop.to_string_internal("VIEW"),
             SQLStatement::SQLAlterTable { name, operation } => {
                 format!("ALTER TABLE {} {}", name.to_string(), operation.to_string())
             }
@@ -608,3 +614,28 @@ impl FromStr for FileFormat {
         }
     }
 }
+
+#[derive(Debug, Clone, PartialEq)]
+pub struct SQLDrop {
+    pub if_exists: bool,
+    pub names: Vec<SQLObjectName>,
+    pub cascade: bool,
+    pub restrict: bool,
+}
+
+impl SQLDrop {
+    fn to_string_internal(&self, object_type: &str) -> String {
+        format!(
+            "DROP {}{} {}{}{}",
+            object_type,
+            if self.if_exists { " IF EXISTS" } else { "" },
+            self.names
+                .iter()
+                .map(|name| name.to_string())
+                .collect::<Vec<String>>()
+                .join(", "),
+            if self.cascade { " CASCADE" } else { "" },
+            if self.restrict { " RESTRICT" } else { "" },
+        )
+    }
+}

src/sqlparser.rs

@@ -97,6 +97,7 @@ impl Parser {
                         Ok(SQLStatement::SQLQuery(Box::new(self.parse_query()?)))
                     }
                     "CREATE" => Ok(self.parse_create()?),
+                    "DROP" => Ok(self.parse_drop()?),
                     "DELETE" => Ok(self.parse_delete()?),
                     "INSERT" => Ok(self.parse_insert()?),
                     "ALTER" => Ok(self.parse_alter()?),
@@ -738,6 +739,51 @@ impl Parser {
         })
     }
 
+    pub fn parse_drop(&mut self) -> Result<SQLStatement, ParserError> {
+        if self.parse_keyword("TABLE") {
+            self.parse_drop_table()
+        } else if self.parse_keyword("VIEW") {
+            self.parse_drop_view()
+        } else {
+            parser_err!(format!(
+                "Unexpected token after DROP: {:?}",
+                self.peek_token()
+            ))
+        }
+    }
+
+    pub fn parse_drop_table(&mut self) -> Result<SQLStatement, ParserError> {
+        Ok(SQLStatement::SQLDropTable(self.parse_drop_inner()?))
+    }
+
+    pub fn parse_drop_view(&mut self) -> Result<SQLStatement, ParserError> {
+        Ok(SQLStatement::SQLDropView(self.parse_drop_inner()?))
+    }
+
+    pub fn parse_drop_inner(&mut self) -> Result<SQLDrop, ParserError> {
+        let if_exists = self.parse_keywords(vec!["IF", "EXISTS"]);
+        let mut names = vec![self.parse_object_name()?];
+        loop {
+            let token = &self.next_token();
+            if let Some(Token::Comma) = token {
+                names.push(self.parse_object_name()?)
+            } else {
+                if token.is_some() {
+                    self.prev_token();
+                }
+                break;
+            }
+        }
+        let cascade = self.parse_keyword("CASCADE");
+        let restrict = !cascade && self.parse_keyword("RESTRICT");
+        Ok(SQLDrop {
+            if_exists,
+            names,
+            cascade,
+            restrict,
+        })
+    }
+
     pub fn parse_create_table(&mut self) -> Result<SQLStatement, ParserError> {
         let table_name = self.parse_object_name()?;
         // parse optional column list (schema)

tests/sqlparser_common.rs

@@ -1200,6 +1200,67 @@ fn parse_create_materialized_view() {
     }
 }
 
+#[test]
+fn parse_drop_table() {
+    let sql = "DROP TABLE foo";
+    match verified_stmt(sql) {
+        SQLStatement::SQLDropTable(SQLDrop {
+            if_exists,
+            names,
+            cascade,
+            restrict,
+        }) => {
+            assert_eq!(false, if_exists);
+            assert_eq!(
+                vec!["foo"],
+                names.iter().map(|n| n.to_string()).collect::<Vec<_>>()
+            );
+            assert_eq!(false, cascade);
+            assert_eq!(false, restrict);
+        }
+        _ => assert!(false),
+    }
+
+    let sql = "DROP TABLE IF EXISTS foo, bar CASCADE";
+    match verified_stmt(sql) {
+        SQLStatement::SQLDropTable(SQLDrop {
+            if_exists,
+            names,
+            cascade,
+            restrict,
+        }) => {
+            assert_eq!(true, if_exists);
+            assert_eq!(
+                vec!["foo", "bar"],
+                names.iter().map(|n| n.to_string()).collect::<Vec<_>>()
+            );
+            assert_eq!(true, cascade);
+            assert_eq!(false, restrict);
+        }
+        _ => assert!(false),
+    }
+
+    let sql = "DROP TABLE";
+    assert!(parse_sql_statements(sql).is_err());
+
+    let sql = "DROP TABLE IF EXISTS foo, bar CASCADE RESTRICT";
+    assert!(parse_sql_statements(sql).is_err());
+}
+
+#[test]
+fn parse_drop_view() {
+    let sql = "DROP VIEW myschema.myview";
+    match verified_stmt(sql) {
+        SQLStatement::SQLDropView(SQLDrop { names, .. }) => {
+            assert_eq!(
+                vec!["myschema.myview"],
+                names.iter().map(|n| n.to_string()).collect::<Vec<_>>()
+            );
+        }
+        _ => assert!(false),
+    }
+}
+
 #[test]
 fn parse_invalid_subquery_without_parens() {
     let res = parse_sql_statements("SELECT SELECT 1 FROM bar WHERE 1=1 FROM baz");