Skip to content

Commit 08ebd9f

Browse files
committed
tweaks
1 parent c4aa802 commit 08ebd9f

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

src/parser.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ impl std::error::Error for ParserError {}
195195
// By default, allow expressions up to this deep before erroring
196196
const DEFAULT_REMAINING_DEPTH: usize = 50;
197197

198-
#[derive(Default, Clone)]
198+
#[derive(Debug, Default, Clone, PartialEq, Eq)]
199199
pub struct ParserOptions {
200200
pub trailing_commas: bool,
201201
}

tests/sqlparser_common.rs

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6896,18 +6896,20 @@ fn parse_trailing_comma() {
68966896
}),
68976897
};
68986898

6899-
// We shouldn't verify, because trailing commas will not get generated back
6900-
trailing_commas
6901-
.parse_sql_statements("SELECT album_id, name, FROM track")
6902-
.unwrap();
6903-
6904-
trailing_commas
6905-
.parse_sql_statements("SELECT * FROM track ORDER BY milliseconds,")
6906-
.unwrap();
6907-
6908-
trailing_commas
6909-
.parse_sql_statements("SELECT DISTINCT ON (album_id,) name FROM track")
6910-
.unwrap();
6899+
trailing_commas.one_statement_parses_to(
6900+
"SELECT album_id, name, FROM track",
6901+
"SELECT album_id, name FROM track",
6902+
);
6903+
6904+
trailing_commas.one_statement_parses_to(
6905+
"SELECT * FROM track ORDER BY milliseconds,",
6906+
"SELECT * FROM track ORDER BY milliseconds",
6907+
);
6908+
6909+
trailing_commas.one_statement_parses_to(
6910+
"SELECT DISTINCT ON (album_id,) name FROM track",
6911+
"SELECT DISTINCT ON (album_id) name FROM track",
6912+
);
69116913

69126914
trailing_commas.verified_stmt("SELECT album_id, name FROM track");
69136915

0 commit comments

Comments
 (0)