Skip to content

Commit cc3a7d2

Browse files
committed
fix comments
1 parent 3ac436b commit cc3a7d2

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

cpp/src/plasma/client.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,9 @@ ARROW_DEPRECATED("PLASMA_DEFAULT_RELEASE_DELAY is deprecated")
3838
constexpr int64_t kDeprecatedPlasmaDefaultReleaseDelay = 64;
3939
#define PLASMA_DEFAULT_RELEASE_DELAY kDeprecatedPlasmaDefaultReleaseDelay;
4040

41-
/// Number of objects that will be kept unreleased in the plasma client
42-
/// until we send a message to the store to release the object.
41+
/// We keep a queue of unreleased objects cached in the client until we start
42+
/// sending release requests to the store. This is to avoid frequently mapping
43+
/// and unmapping objects and evicting data from processor caches.
4344
constexpr int64_t kPlasmaDefaultReleaseDelay = 64;
4445

4546
/// Object buffer data structure.

cpp/src/plasma/format/plasma.fbs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
// Plasma protocol specification
1919

2020
enum MessageType:int {
21+
// Message that gets send when a client hangs up.
2122
PlasmaDisconnectClient = 0,
2223
// Create a new object.
2324
PlasmaCreateRequest,

cpp/src/plasma/io.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ using arrow::Status;
3030

3131
/// Number of times we try connecting to a socket.
3232
constexpr int64_t kNumConnectAttempts = 50;
33-
/// Time to wait between connection attempts.
33+
/// Time to wait between connection attempts to a socket.
3434
constexpr int64_t kConnectTimeoutMs = 100;
3535

3636
namespace plasma {

0 commit comments

Comments
 (0)