ARROW-7552: [C++] [CI] Disable timing-sensitive tests on public CI

Closes #6173 from pitrou/ARROW-7552-disable-timing-tests and squashes the following commits:

da2ccb2 <Antoine Pitrou> ARROW-7552:   Disable timing-sensitive tests on public CI

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Wes McKinney <[email protected]>

Author: pitrou

.github/workflows/cpp.yml

@@ -30,6 +30,9 @@ on:
       - 'ci/**'
       - 'cpp/**'
 
+env:
+  ARROW_ENABLE_TIMING_TESTS: OFF
+
 jobs:
 
   conda:

.github/workflows/cpp_cron.yml

@@ -29,6 +29,9 @@ on:
     - cron: |
         0 */12 * * *
 
+env:
+  ARROW_ENABLE_TIMING_TESTS: OFF
+
 jobs:
 
   debian:

ci/appveyor-cpp-build.bat

@@ -41,6 +41,7 @@ if "%JOB%" == "Static_Crt_Build" (
         -DARROW_BUILD_TESTS=ON ^
         -DARROW_BUILD_EXAMPLES=ON ^
         -DCMAKE_BUILD_TYPE=Debug ^
+        -DARROW_ENABLE_TIMING_TESTS=OFF ^
         -DARROW_TEST_LINKAGE=static ^
         -DARROW_CXXFLAGS="/MP" ^
         ..  || exit /B
@@ -61,6 +62,7 @@ if "%JOB%" == "Static_Crt_Build" (
         -DARROW_BUILD_TESTS=ON ^
         -DARROW_BUILD_EXAMPLES=ON ^
         -DCMAKE_BUILD_TYPE=Release ^
+        -DARROW_ENABLE_TIMING_TESTS=OFF ^
         -DARROW_TEST_LINKAGE=static ^
         -DCMAKE_CXX_FLAGS_RELEASE="/MT %CMAKE_CXX_FLAGS_RELEASE%" ^
         -DARROW_CXXFLAGS="/WX /MP" ^
@@ -90,6 +92,7 @@ if "%JOB%" == "Build_Debug" (
         -DCMAKE_BUILD_TYPE=%CONFIGURATION% ^
         -DARROW_BUILD_STATIC=OFF ^
         -DARROW_CXXFLAGS="/MP" ^
+        -DARROW_ENABLE_TIMING_TESTS=OFF ^
         ..  || exit /B
 
   cmake --build . --config %CONFIGURATION% || exit /B

ci/cpp-msvc-build-main.bat

@@ -19,7 +19,7 @@
 @rem (i.e. for usual configurations)
 
 set ARROW_HOME=%CONDA_PREFIX%\Library
-set CMAKE_ARGS=-DARROW_VERBOSE_THIRDPARTY_BUILD=OFF
+set CMAKE_ARGS=-DARROW_VERBOSE_THIRDPARTY_BUILD=OFF -DARROW_ENABLE_TIMING_TESTS=OFF
 
 if "%JOB%" == "Toolchain" (
   set CMAKE_ARGS=^

ci/scripts/cpp_build.sh

@@ -60,6 +60,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
       -DARROW_DATASET=${ARROW_DATASET:-ON} \
       -DARROW_DEPENDENCY_SOURCE=${ARROW_DEPENDENCY_SOURCE:-AUTO} \
       -DARROW_EXTRA_ERROR_CONTEXT=${ARROW_EXTRA_ERROR_CONTEXT:-OFF} \
+      -DARROW_ENABLE_TIMING_TESTS=${ARROW_ENABLE_TIMING_TESTS:-ON} \
       -DARROW_FILESYSTEM=${ARROW_FILESYSTEM:-ON} \
       -DARROW_FLIGHT=${ARROW_FLIGHT:-OFF} \
       -DARROW_FUZZING=${ARROW_FUZZING:-OFF} \

cpp/CMakeLists.txt

@@ -322,6 +322,10 @@ else()
   add_dependencies(unittest all-tests)
 endif()
 
+if(ARROW_ENABLE_TIMING_TESTS)
+  add_definitions(-DARROW_WITH_TIMING_TESTS)
+endif()
+
 if(NOT ARROW_BUILD_BENCHMARKS)
   set(NO_BENCHMARKS 1)
 else()

cpp/cmake_modules/DefineOptions.cmake

@@ -113,6 +113,8 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
 
   define_option(ARROW_BUILD_TESTS "Build the Arrow googletest unit tests" OFF)
 
+  define_option(ARROW_ENABLE_TIMING_TESTS "Enable timing-sensitive tests" ON)
+
   define_option(ARROW_BUILD_INTEGRATION "Build the Arrow integration test executables"
                 OFF)
 

cpp/src/arrow/flight/flight_test.cc

@@ -984,7 +984,11 @@ TEST_F(TestFlightClient, TimeoutFires) {
   auto start = std::chrono::system_clock::now();
   Status status = client->GetFlightInfo(options, FlightDescriptor{}, &info);
   auto end = std::chrono::system_clock::now();
+#ifdef ARROW_WITH_TIMING_TESTS
   EXPECT_LE(end - start, std::chrono::milliseconds{400});
+#else
+  ARROW_UNUSED(end - start);
+#endif
   ASSERT_RAISES(IOError, status);
 }
 
@@ -997,7 +1001,11 @@ TEST_F(TestFlightClient, NoTimeout) {
   auto descriptor = FlightDescriptor::Path({"examples", "ints"});
   Status status = client_->GetFlightInfo(options, descriptor, &info);
   auto end = std::chrono::system_clock::now();
+#ifdef ARROW_WITH_TIMING_TESTS
   EXPECT_LE(end - start, std::chrono::milliseconds{600});
+#else
+  ARROW_UNUSED(end - start);
+#endif
   ASSERT_OK(status);
   ASSERT_NE(nullptr, info);
 }

cpp/src/arrow/io/memory_test.cc

@@ -305,8 +305,12 @@ void TestSlowInputStream() {
   auto t2 = clock::now();
   AssertBufferEqual(*buf, "abcdef");
   auto dt = std::chrono::duration_cast<std::chrono::duration<double>>(t2 - t1).count();
+#ifdef ARROW_WITH_TIMING_TESTS
   ASSERT_LT(dt, latency * 3);  // likely
   ASSERT_GT(dt, latency / 3);  // likely
+#else
+  ARROW_UNUSED(dt);
+#endif
 
   ASSERT_OK_AND_ASSIGN(util::string_view view, slow->Peek(4));
   ASSERT_EQ(view, util::string_view("ghij"));

cpp/src/arrow/util/logging_test.cc

@@ -68,6 +68,8 @@ TEST(PrintLogTest, LogTestWithInit) {
   ArrowLog::ShutDownArrowLog();
 }
 
+#ifdef ARROW_WITH_TIMING_TESTS
+
 // This test will output large amount of logs to stderr, should be disabled in travis.
 TEST(LogPerfTest, PerfTest) {
   ArrowLog::StartArrowLog("/fake/path/to/appdire/LogPerfTest", ArrowLogLevel::ARROW_ERROR,
@@ -103,6 +105,8 @@ TEST(LogPerfTest, PerfTest) {
   ArrowLog::ShutDownArrowLog();
 }
 
+#endif
+
 }  // namespace util
 
 TEST(DcheckMacros, DoNotEvaluateReleaseMode) {

cpp/src/arrow/util/macros.h

@@ -36,7 +36,7 @@
   TypeName& operator=(TypeName&&) = default
 #endif
 
-#define ARROW_UNUSED(x) (void)x
+#define ARROW_UNUSED(x) (void)(x)
 #define ARROW_ARG_UNUSED(x)
 //
 // GCC can be told that a certain branch is not likely to be taken (for

docker-compose.yml

@@ -84,6 +84,7 @@ services:
     shm_size: &shm-size 2G
     environment:
       <<: *ccache
+      ARROW_ENABLE_TIMING_TESTS:  # inherit
     volumes: &conda-volumes
       - .:/arrow:delegated
       - ${ARCH}-conda-cache:/build:delegated
@@ -109,6 +110,7 @@ services:
     shm_size: *shm-size
     environment:
       <<: *ccache
+      ARROW_ENABLE_TIMING_TESTS:  # inherit
     volumes: &cuda-volumes
       - .:/arrow:delegated
       - ${ARCH}-cuda-${CUDA}-cache:/build:delegated
@@ -135,6 +137,7 @@ services:
     shm_size: *shm-size
     environment:
       <<: *ccache
+      ARROW_ENABLE_TIMING_TESTS:  # inherit
     volumes: &debian-volumes
       - .:/arrow:delegated
       - ${ARCH}-debian-${DEBIAN}-cache:/build:delegated
@@ -158,6 +161,7 @@ services:
     shm_size: *shm-size
     environment:
       <<: *ccache
+      ARROW_ENABLE_TIMING_TESTS:  # inherit
     volumes: &ubuntu-volumes
       - .:/arrow:delegated
       - ${ARCH}-ubuntu-${UBUNTU}-cache:/build:delegated
@@ -187,6 +191,7 @@ services:
       <<: *ccache
       CC: clang-7
       CXX: clang++-7
+      ARROW_ENABLE_TIMING_TESTS:  # inherit
       ARROW_JEMALLOC: "OFF"
       ARROW_ORC: "OFF"
       ARROW_USE_ASAN: "ON"
@@ -211,6 +216,7 @@ services:
     shm_size: *shm-size
     environment:
       <<: *ccache
+      ARROW_ENABLE_TIMING_TESTS:  # inherit
     volumes: &fedora-volumes
       - .:/arrow:delegated
       - ${ARCH}-fedora-${FEDORA}-cache:/build:delegated