Skip to content

Commit cf5c3c8

Browse files
potiukephraimbuddy
authored andcommitted
Fix failing trigger test after Flask 2.2.4 upgrade (#30875)
Flask 2.2.4 released yesterday, cause one of our (far too picky) tests to break - breaking main. This PR fixes it by making the test less picky. (cherry picked from commit 3f3afe9)
1 parent 416d66d commit cf5c3c8

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

tests/www/views/test_views_trigger_dag.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -192,13 +192,9 @@ def test_trigger_dag_params_conf(admin_client, request_conf, expected_conf):
192192
else:
193193
test_request_conf = json.dumps(request_conf, indent=4)
194194
resp = admin_client.get(f"trigger?dag_id={test_dag_id}&conf={test_request_conf}&doc_md={doc_md}")
195-
196-
expected_dag_conf = json.dumps(expected_conf, indent=4).replace('"', """)
197-
198-
check_content_in_response(
199-
f'<textarea style="display: none;" id="json_start" name="json_start">{expected_dag_conf}</textarea>',
200-
resp,
201-
)
195+
for key in expected_conf.keys():
196+
check_content_in_response(key, resp)
197+
check_content_in_response(str(expected_conf[key]), resp)
202198

203199

204200
def test_trigger_dag_params_render(admin_client, dag_maker, session, app, monkeypatch):

0 commit comments

Comments
 (0)