Skip to content

Commit e5c33e7

Browse files
committed
build: Bump minimum Go version to 1.19
Signed-off-by: Anoop C S <[email protected]>
1 parent 080152c commit e5c33e7

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

.github/workflows/main.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
steps:
1414
- uses: actions/setup-go@v3
1515
with:
16-
go-version: "1.18"
16+
go-version: "1.19"
1717
- uses: actions/checkout@v3
1818
- name: Build
1919
run: make
@@ -23,7 +23,7 @@ jobs:
2323
steps:
2424
- uses: actions/setup-go@v3
2525
with:
26-
go-version: "1.18"
26+
go-version: "1.19"
2727
- uses: actions/checkout@v3
2828
- name: Install revive
2929
run: go install github.com/mgechev/revive@latest
@@ -46,7 +46,7 @@ jobs:
4646
steps:
4747
- uses: actions/setup-go@v3
4848
with:
49-
go-version: "1.18"
49+
go-version: "1.19"
5050
- uses: actions/checkout@v3
5151
- name: run the tests
5252
run: make test
@@ -100,7 +100,7 @@ jobs:
100100
- uses: actions/checkout@v3
101101
- uses: actions/setup-go@v3
102102
with:
103-
go-version: "1.18"
103+
go-version: "1.19"
104104
- name: Install k3d
105105
run: curl -L --silent --fail "https://raw.githubusercontent.com/rancher/k3d/main/install.sh" | bash
106106
# The TAG env var can interfere with the k3d install script.

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Build the manager binary
2-
FROM docker.io/golang:1.18 as builder
2+
FROM docker.io/golang:1.19 as builder
33
ARG GIT_VERSION="(unset)"
44
ARG COMMIT_ID="(unset)"
55
ARG ARCH=""

docs/CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ resources.
1717
Development effort takes place using Linux environment and requires at
1818
minimum:
1919

20-
1. [Go 1.18](https://golang.org/dl/) installed
20+
1. [Go 1.19](https://golang.org/dl/) installed
2121
2. [GitHub](https://github.com/) account
2222
3. Development tools: git, make, and podman or docker
2323
4. Testing: [minikube](https://minikube.sigs.k8s.io)

docs/developers-notes.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
## Build from source
55

66
The top-level [Makefile](../Makefile) is the entry point for various build
7-
commands. The minimal required Go version is 1.18. A developer can verify the
7+
commands. The minimal required Go version is 1.19. A developer can verify the
88
build environment by running:
99

1010
```bash

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/samba-in-kubernetes/samba-operator
22

3-
go 1.18
3+
go 1.19
44

55
require (
66
github.com/go-logr/logr v1.2.3

tests/centosci/sink-clustered-deployment.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ setup_minikube
1313

1414
deploy_rook
1515

16-
image_pull "${CI_IMG_REGISTRY}" "docker.io" "golang:1.18"
16+
image_pull "${CI_IMG_REGISTRY}" "docker.io" "golang:1.19"
1717

1818
# Build and push operator image to local CI registry
1919
IMG="${CI_IMG_OP}" make image-build

0 commit comments

Comments
 (0)