Skip to content

Commit 9db2ff1

Browse files
committed
fix(win_mmap): unmark hidden win_errors due to smmap unicode foes
Now 2 more TCs pass in Windows: + TestRepo.test_file_handle_leaks() + TestObjDbPerformance.test_random_access() See gitpython-developers/smmap#30
1 parent 3910abf commit 9db2ff1

File tree

3 files changed

+0
-9
lines changed

3 files changed

+0
-9
lines changed

Diff for: git/test/performance/test_odb.py

-6
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33

44
import sys
55
from time import time
6-
from unittest.case import skipIf
7-
8-
from git.compat import PY3
9-
from git.util import HIDE_WINDOWS_KNOWN_ERRORS
106

117
from .lib import (
128
TestBigRepoR
@@ -15,8 +11,6 @@
1511

1612
class TestObjDBPerformance(TestBigRepoR):
1713

18-
@skipIf(HIDE_WINDOWS_KNOWN_ERRORS and PY3,
19-
"FIXME: smmp fails with: TypeError: Can't convert 'bytes' object to str implicitly")
2014
def test_random_access(self):
2115
results = [["Iterate Commits"], ["Iterate Blobs"], ["Retrieve Blob Data"]]
2216
for repo in (self.gitrorepo, self.puregitrorepo):

Diff for: git/test/test_repo.py

-2
Original file line numberDiff line numberDiff line change
@@ -808,8 +808,6 @@ def test_git_file(self, rwrepo):
808808
git_file_repo = Repo(rwrepo.working_tree_dir)
809809
self.assertEqual(osp.abspath(git_file_repo.git_dir), real_path_abs)
810810

811-
@skipIf(HIDE_WINDOWS_KNOWN_ERRORS and PY3,
812-
"FIXME: smmp fails with: TypeError: Can't convert 'bytes' object to str implicitly")
813811
def test_file_handle_leaks(self):
814812
def last_commit(repo, rev, path):
815813
commit = next(repo.iter_commits(rev, path, max_count=1))

Diff for: git/test/test_submodule.py

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
from git.cmd import Git
1010
from git.compat import (
1111
string_types,
12-
is_win,
1312
)
1413
from git.exc import (
1514
InvalidGitRepositoryError,

0 commit comments

Comments
 (0)