From caaea7ba89c71e81a8640bbd32d7ac68de4fa770 Mon Sep 17 00:00:00 2001 From: Maxime Robert Date: Tue, 18 Feb 2020 21:07:26 +0100 Subject: [PATCH 1/2] Explicitly say that 'firebase/firestore' must be imported It is easy to miss this import and don't understand why this quickstart doesn't work. --- docs/install-and-setup.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/install-and-setup.md b/docs/install-and-setup.md index bfec375f4..02d2541ad 100644 --- a/docs/install-and-setup.md +++ b/docs/install-and-setup.md @@ -88,7 +88,7 @@ export class AppModule {} ### 7. Inject `AngularFirestore` -Open `/src/app/app.component.ts`, and make sure to modify/delete any tests to get the sample working (tests are still important, you know): +Open `/src/app/app.component.ts`, and make sure to `import 'firebase/firestore';`. Also, modify/delete any tests to get the sample working (tests are still important, you know): ```ts import { Component } from '@angular/core'; From cd5545d561d15604fcef93c6f11fb051212f467d Mon Sep 17 00:00:00 2001 From: Maxime Robert Date: Fri, 21 Feb 2020 22:49:14 +0100 Subject: [PATCH 2/2] Update docs/install-and-setup.md Co-Authored-By: Michael Prentice --- docs/install-and-setup.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/install-and-setup.md b/docs/install-and-setup.md index 02d2541ad..f01a267ff 100644 --- a/docs/install-and-setup.md +++ b/docs/install-and-setup.md @@ -88,7 +88,7 @@ export class AppModule {} ### 7. Inject `AngularFirestore` -Open `/src/app/app.component.ts`, and make sure to `import 'firebase/firestore';`. Also, modify/delete any tests to get the sample working (tests are still important, you know): +Open `/src/app/app.component.ts`, add `import 'firebase/firestore';`, and inject `AngularFirestore` in the constructor. Then remember to update your tests to get them passing (tests are still important): ```ts import { Component } from '@angular/core';