From 3fa71b8908a97f089f7ebc64968316b32576e340 Mon Sep 17 00:00:00 2001 From: stuart Date: Tue, 19 Mar 2019 13:13:57 -0500 Subject: [PATCH 1/3] Misnamed method: updateMetatdata should be updateMetadata. --- src/storage/ref.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage/ref.ts b/src/storage/ref.ts index 8b7c1e276..715239793 100644 --- a/src/storage/ref.ts +++ b/src/storage/ref.ts @@ -8,7 +8,7 @@ export interface AngularFireStorageReference { getMetadata(): Observable; delete(): Observable; child(path: string): any; - updateMetatdata(meta: SettableMetadata): Observable; + updateMetadata(meta: SettableMetadata): Observable; put(data: any, metadata?: UploadMetadata | undefined): AngularFireUploadTask; putString(data: string, format?: string | undefined, metadata?: UploadMetadata | undefined): AngularFireUploadTask; } @@ -32,7 +32,7 @@ export function createStorageRef(ref: Reference, scheduler: FirebaseZoneSchedule ), delete: () => from(ref.delete()), child: (path: string) => createStorageRef(ref.child(path), scheduler), - updateMetatdata: (meta: SettableMetadata) => from(ref.updateMetadata(meta)), + updateMetadata: (meta: SettableMetadata) => from(ref.updateMetadata(meta)), put: (data: any, metadata?: UploadMetadata) => { const task = ref.put(data, metadata); return createUploadTask(task); From 18a09897a6d298968c2cdd9d369b8257ee1768de Mon Sep 17 00:00:00 2001 From: stuart Date: Tue, 19 Mar 2019 13:16:42 -0500 Subject: [PATCH 2/3] Misnamed method: updateMetatdata should be updateMetadata. Keeping old method name for short-term, backward compatibility? --- src/storage/ref.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/storage/ref.ts b/src/storage/ref.ts index 715239793..dd3e46b90 100644 --- a/src/storage/ref.ts +++ b/src/storage/ref.ts @@ -8,6 +8,7 @@ export interface AngularFireStorageReference { getMetadata(): Observable; delete(): Observable; child(path: string): any; + updateMetatdata(meta: SettableMetadata): Observable; updateMetadata(meta: SettableMetadata): Observable; put(data: any, metadata?: UploadMetadata | undefined): AngularFireUploadTask; putString(data: string, format?: string | undefined, metadata?: UploadMetadata | undefined): AngularFireUploadTask; @@ -32,6 +33,7 @@ export function createStorageRef(ref: Reference, scheduler: FirebaseZoneSchedule ), delete: () => from(ref.delete()), child: (path: string) => createStorageRef(ref.child(path), scheduler), + updateMetatdata: (meta: SettableMetadata) => from(ref.updateMetatdata(meta)), updateMetadata: (meta: SettableMetadata) => from(ref.updateMetadata(meta)), put: (data: any, metadata?: UploadMetadata) => { const task = ref.put(data, metadata); From 2ca03a8ae2724fad0bbf9f5e5992f5c3e6730591 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Mon, 29 Apr 2019 19:26:20 -0700 Subject: [PATCH 3/3] from shouldn't be misspelt --- src/storage/ref.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/ref.ts b/src/storage/ref.ts index dd3e46b90..daa85643f 100644 --- a/src/storage/ref.ts +++ b/src/storage/ref.ts @@ -33,7 +33,7 @@ export function createStorageRef(ref: Reference, scheduler: FirebaseZoneSchedule ), delete: () => from(ref.delete()), child: (path: string) => createStorageRef(ref.child(path), scheduler), - updateMetatdata: (meta: SettableMetadata) => from(ref.updateMetatdata(meta)), + updateMetatdata: (meta: SettableMetadata) => from(ref.updateMetadata(meta)), updateMetadata: (meta: SettableMetadata) => from(ref.updateMetadata(meta)), put: (data: any, metadata?: UploadMetadata) => { const task = ref.put(data, metadata);