From aa8c3feaaef7e6d500c6b4c56e8a3f541f4c256b Mon Sep 17 00:00:00 2001 From: Jemonge Date: Wed, 24 Oct 2018 21:44:06 -0600 Subject: [PATCH 1/2] Update messaging.ts Fix a breaking bug. It's not calling firebase/messaging correctly. --- src/messaging/messaging.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/messaging/messaging.ts b/src/messaging/messaging.ts index 9d9cb37a0..b4555f18b 100644 --- a/src/messaging/messaging.ts +++ b/src/messaging/messaging.ts @@ -26,7 +26,7 @@ export class AngularFireMessaging { if (isPlatformBrowser(platformId)) { // @ts-ignore - const requireMessaging = from(import('firebase/messaging')); + const requireMessaging = require('firebase/messaging'); this.messaging = requireMessaging.pipe( map(() => _firebaseAppFactory(options, nameOrConfig)), From a43dde2225a03ac616014c3f5d93d6c6fe7c5273 Mon Sep 17 00:00:00 2001 From: Jemonge Date: Thu, 25 Oct 2018 20:42:28 -0600 Subject: [PATCH 2/2] Update messaging.ts --- src/messaging/messaging.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/messaging/messaging.ts b/src/messaging/messaging.ts index b4555f18b..1a2a7583b 100644 --- a/src/messaging/messaging.ts +++ b/src/messaging/messaging.ts @@ -26,7 +26,7 @@ export class AngularFireMessaging { if (isPlatformBrowser(platformId)) { // @ts-ignore - const requireMessaging = require('firebase/messaging'); + const requireMessaging = from(require('firebase/messaging')); this.messaging = requireMessaging.pipe( map(() => _firebaseAppFactory(options, nameOrConfig)),