Skip to content

Upgrade to RC6 #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asadsahi opened this issue Sep 2, 2016 · 12 comments
Closed

Upgrade to RC6 #493

asadsahi opened this issue Sep 2, 2016 · 12 comments
Assignees
Milestone

Comments

@asadsahi
Copy link

asadsahi commented Sep 2, 2016

Hi,

I have upgraded one of my application to angular 2 RC6 today and after that firebase authentication isn't working as expected. With RC5 FirebaseAuth service subscription was working, but I suspect something wrong with this service that it isn't raising events which breaks setting the authentication state after success.

Here is my app on github: https://github.com/asadsahi/ng2fb-bootstrap

Code is in the:
https://github.com/asadsahi/ng2fb-bootstrap/blob/master/src/app/shared/services/auth.service.ts

@davideast
Copy link
Collaborator

AngularFire2 isn't on RC6 yet. For the time being downgrade to RC5 if you require AngularFire2, but we are working on the upgrade soon.

@davideast davideast changed the title Angular 2 RC6 Upgrade has broken the authentication Upgrade to RC6 Sep 2, 2016
@davideast davideast added this to the beta.5 milestone Sep 2, 2016
@davideast davideast self-assigned this Sep 2, 2016
@asadsahi
Copy link
Author

asadsahi commented Sep 2, 2016

no problem, thanks @davideast . I will wait until new version is released supporting RC6.

@orangesoup
Copy link

@asadsahi The only thing you need to do probably is reverting rxjs back to beta.10 from beta.11.

@asadsahi
Copy link
Author

asadsahi commented Sep 3, 2016

It worked. Magic 👍

Thanks @orangesoup, will stick to rxjs xx.10 until next release of angularfire2 fixes it I guess.

@Meistercoach83
Copy link
Contributor

@davideast when do you think will angularfire be ready to use beta.11 / rc6?

@andreigiura
Copy link

Hi, i have an error while trying to user angularfire2 with rc5: No provider for Token FirebaseUrl!

imports
....
...

import {FIREBASE_PROVIDERS,
defaultFirebase,
AngularFire,
AuthMethods,
AuthProviders,
firebaseAuthConfig} from 'angularfire2';

@NgModule({
declarations: [Myapp],
imports: [BrowserModule],
bootstrap: [Myapp],
providers: [FIREBASE_PROVIDERS]
})
export class AppModule {}

platformBrowserDynamic().bootstrapModule(AppModule);

@andreigiura
Copy link

I figured it out, i had to set the defaultFirebase({apiKey: xxx, authDomain: xxx, ...}) as a provider too

@danielgek
Copy link

@andreigiura see step 3 here

@thebishorup
Copy link

I followed the steps to install the AngularFire in project but I am getting following error with RC5.

http://localhost:4200/angularfire2 Failed to load resource: the server responded with a status of 404 (Not Found)
zone.js:461 Unhandled Promise rejection: Error: XHR error (404 Not Found) loading http://localhost:4200/angularfire2
at XMLHttpRequest.wrapFn as _onreadystatechange
at ZoneDelegate.invokeTask (http://localhost:4200/vendor/zone.js/dist/zone.js:356:38)
at Zone.runTask (http://localhost:4200/vendor/zone.js/dist/zone.js:256:48)
at XMLHttpRequest.ZoneTask.invoke (http://localhost:4200/vendor/zone.js/dist/zone.js:423:34)
Error loading http://localhost:4200/angularfire2 as "angularfire2" from http://localhost:4200/app/app.module.js ; Zone: ; Task: Promise.then ; Value: Error: Error: XHR error (404 Not Found) loading http://localhost:4200/angularfire2(…)consoleError @ zone.js:461
zone.js:463 Error: Uncaught (in promise): Error: Error: XHR error (404 Not Found) loading http://localhost:4200/angularfire2(…)

@ryanlangton
Copy link

Is this being actively worked on? I looked through the source and it doesn't seem like a huge amount of effort to update (but looks can be deceiving). Hoping there is an update soon because it seems there are other version problems that cause AF2 to not work with Angular RC6.

@davideast
Copy link
Collaborator

@ryanlangton This repository is actively being worked on. We have a beta.5 milestone in place here on GitHub. You should see an update sometime this week.

@davideast
Copy link
Collaborator

RC7 upgrade is merged. Up next 2.0 final (which is the same thing really)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants