Skip to content

Update peer dependencies to new Angular version 12 #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CrlsMrls opened this issue May 16, 2021 · 3 comments
Closed

Update peer dependencies to new Angular version 12 #2829

CrlsMrls opened this issue May 16, 2021 · 3 comments

Comments

@CrlsMrls
Copy link

Version info

Angular: 12.0.0

Firebase: 8.5.0

AngularFire: 6.1.4

How to reproduce these conditions

Steps to set up and reproduce

  • update Angular to v 12 ng update @angular/core@12 @angular/cli@12
  • clear node_modules folder
  • install npm modules with yarn or npm install

Expected behavior

Peer dependencies are met.

Actual behavior

warning " > @angular/[email protected]" has incorrect peer dependency "@angular/common@^9.0.0 || ^10.0.0 || ^11.0.0".
warning " > @angular/[email protected]" has incorrect peer dependency "@angular/core@^9.0.0 || ^10.0.0 || ^11.0.0".
warning " > @angular/[email protected]" has incorrect peer dependency "@angular/platform-browser@^9.0.0 || ^10.0.0 || ^11.0.0".
warning " > @angular/[email protected]" has incorrect peer dependency "@angular/platform-browser-dynamic@^9.0.0 || ^10.0.0 || ^11.0.0".
@google-oss-bot
Copy link

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@CrlsMrls
Copy link
Author

My applications worked perfectly fine with the new Angular 12 and AngularFire 6.1.4

@abraham
Copy link

abraham commented May 17, 2021

With npm@7 this causes installs to fail.

$ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"12.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^9.0.0 || ^10.0.0 || ^11.0.0" from @angular/[email protected]
npm ERR! node_modules/@angular/fire
npm ERR!   @angular/fire@"6.1.4" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants