We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All my dependencies :
"@angular/animations": "^10.2.0", "@angular/cdk": "^10.2.5", "@angular/common": "^10.2.0", "@angular/compiler": "^10.2.0", "@angular/core": "^10.2.0", "@angular/fire": "^6.0.4", "@angular/flex-layout": "^10.0.0-beta.32", "@angular/forms": "^10.2.0", "@angular/material": "^10.2.5", "@angular/platform-browser": "^10.2.0", "@angular/platform-browser-dynamic": "^10.2.0", "@angular/platform-server": "^10.2.0", "@angular/router": "^10.2.0", "@datorama/akita": "^5.2.5", "@datorama/akita-ng-router-store": "^5.1.8", "@ngneat/until-destroy": "^8.0.3", "@nguniversal/express-engine": "^10.1.0", "akita-ng-fire": "^3.1.7", "canvas": "^2.6.1", "core-js": "^3.1.4", "firebase": "^8.0.1", "lunr": "^2.3.9", "ng-katex": "^2.0.3", "ng-lazyload-image": "^9.0.1", "ngx-color": "^6.0.1", "ngx-cookie-service": "^10.0.1", "ngx-quicklink": "^0.2.4", "rxjs": "~6.6.3", "tslib": "^1.10.0", "undefined": "^0.1.0", "zone.js": "~0.10.2"
Not getting message about commonjs during the build
applications-suite.module.ts depends on '@angular/fire/firestore'. CommonJS or AMD dependencies can cause optimization bailouts.
My applications-suite.module.ts
import { NgModule } from '@angular/core'; import { CommonModule } from '@angular/common'; import {ApplicationsSuiteComponent} from './applications-suite.component'; import { MatButtonModule } from '@angular/material/button'; import { MatIconModule } from '@angular/material/icon'; import { MatSidenavModule } from '@angular/material/sidenav'; import {LayoutModule} from '@angular/cdk/layout'; import {ApplicationsSuiteRoutingModule} from './applications-suite-routing.module'; import {SuiteNavbarModule} from './suite-navbar/suite-navbar.module'; import {LegalModule} from '../../shared/legal/legal.module'; import {AngularFirestoreModule} from '@angular/fire/firestore'; @NgModule({ declarations: [ ApplicationsSuiteComponent, ], imports: [ CommonModule, AngularFirestoreModule, ApplicationsSuiteRoutingModule, MatSidenavModule, MatButtonModule, MatIconModule, LayoutModule, SuiteNavbarModule, LegalModule, ] }) export class ApplicationsSuiteModule { }
By updating to Firebase 8 and @angular/fire 6.0.4, I remove all firebase and @angular/fire from allowedCommonJsDependencies.
The text was updated successfully, but these errors were encountered:
Per the comment here, it seems like this is a false positive with ngcc #2565 (comment)
Sorry, something went wrong.
Pinning since a lot of folk are running into this.
This now seems to be fully resolved with the latest versions. Closing and unpinning.
No branches or pull requests
All my dependencies :
Expected behavior
Not getting message about commonjs during the build
Actual behavior
applications-suite.module.ts depends on '@angular/fire/firestore'. CommonJS or AMD dependencies can cause optimization bailouts.
My applications-suite.module.ts
By updating to Firebase 8 and @angular/fire 6.0.4, I remove all firebase and @angular/fire from allowedCommonJsDependencies.
The text was updated successfully, but these errors were encountered: