-
Notifications
You must be signed in to change notification settings - Fork 2.2k
support firebase 7 with @angular/fire #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
WIP here #2187. Let me know what you think of the API. |
Hi @jamesdaniels , i'll do that. Awesome! |
So when is this going to go live? I would like to use some of these features in a new app I'm working on but it doesn't look like there is a release with this change yet. |
API looks good for me |
@Dan203 I'll have a release in the next week. Taking a couple days of R&R after getting back from the Firebase Summit roadshow. |
@jamesdaniels any news? |
when can we expect this? |
So, any news about the release, it was expected to have it from about 2 weeks ago. |
I've addressed the peer warning and I've fixed the zone.js issues that were plaguing #2187. Turns out they were affecting the 5.2.1 release too, if you upgraded Firebase and ignored the peer warning. I've fixed these in 5.2.3 (1c3e423, let's just skip over 5.2.2... 😇) With that out of the way, I'll continue to work on the new features. |
Great, would you mind elaborating on the zone.js issues, what problem did it cause for end users? |
Great news! Thanks a lot @jamesdaniels ! About the imminent release of Angular 9, do you think Ivy will have a huge impact of how the library is built ? Hopefully not |
@tgangso if you injected either @johanchouquet I think ng 9 and Ivy will influence us moving forward but I don't foresee any breaks for the time being. I've started including basic ng 9 tests and I have a PR in which I've moved over to ngc building the library but haven't finished due to red tests. I'll be prioritizing that after 5.3. For risk of breaking I might just include that in version 6; which I foresee as 99% API compatible. I'll just be dropping compatibility with older Angular, Typescript, and Firebase versions. |
@jamesdaniels thanks for fixing it, I have been using both and have had some weird subtle issues, maybe this will fix it. |
Releaved to know that our code base would likely not be too much disturbed. Thanks a lot for the clarifications @jamesdaniels ! |
Thanks a lot @jamesdaniels |
Hi,
This is not a bug but a feature request.
In order to benefit the latest goodies of Firebase for the web (remote config, analytics and extensions), it'd be so great that @angular/fire would support Firebase 7.
Do you plan on working on that anytime soon ?
Thanks a lot.
The text was updated successfully, but these errors were encountered: