Skip to content

support firebase 7 with @angular/fire #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johanchouquet opened this issue Oct 3, 2019 · 15 comments
Closed

support firebase 7 with @angular/fire #2189

johanchouquet opened this issue Oct 3, 2019 · 15 comments

Comments

@johanchouquet
Copy link
Contributor

Hi,

This is not a bug but a feature request.

In order to benefit the latest goodies of Firebase for the web (remote config, analytics and extensions), it'd be so great that @angular/fire would support Firebase 7.

Do you plan on working on that anytime soon ?

Thanks a lot.

@jamesdaniels
Copy link
Member

WIP here #2187. Let me know what you think of the API.

@johanchouquet
Copy link
Contributor Author

Hi @jamesdaniels , i'll do that. Awesome!

@Dan203
Copy link

Dan203 commented Oct 17, 2019

So when is this going to go live? I would like to use some of these features in a new app I'm working on but it doesn't look like there is a release with this change yet.

@doczoidberg
Copy link

API looks good for me

@jamesdaniels
Copy link
Member

@Dan203 I'll have a release in the next week. Taking a couple days of R&R after getting back from the Firebase Summit roadshow.

@doczoidberg
Copy link

@jamesdaniels any news?

@tgangso
Copy link

tgangso commented Nov 7, 2019

when can we expect this?

@almothafar
Copy link

So, any news about the release, it was expected to have it from about 2 weeks ago.

@jamesdaniels
Copy link
Member

jamesdaniels commented Nov 12, 2019

I've addressed the peer warning and I've fixed the zone.js issues that were plaguing #2187. Turns out they were affecting the 5.2.1 release too, if you upgraded Firebase and ignored the peer warning. I've fixed these in 5.2.3 (1c3e423, let's just skip over 5.2.2... 😇)

With that out of the way, I'll continue to work on the new features.

@tgangso
Copy link

tgangso commented Nov 12, 2019

@jamesdaniels

Great, would you mind elaborating on the zone.js issues, what problem did it cause for end users?

@johanchouquet
Copy link
Contributor Author

johanchouquet commented Nov 12, 2019

Great news! Thanks a lot @jamesdaniels !

About the imminent release of Angular 9, do you think Ivy will have a huge impact of how the library is built ? Hopefully not

@jamesdaniels
Copy link
Member

@tgangso if you injected either FirebaseApp with Firebase v7 or brought in AngularFirePerformanceModule then your app would never stabilize, disrupting service workers, making SSR impossible, and leading to general (but subtle) mayhem 😛

@johanchouquet I think ng 9 and Ivy will influence us moving forward but I don't foresee any breaks for the time being. I've started including basic ng 9 tests and I have a PR in which I've moved over to ngc building the library but haven't finished due to red tests. I'll be prioritizing that after 5.3. For risk of breaking I might just include that in version 6; which I foresee as 99% API compatible. I'll just be dropping compatibility with older Angular, Typescript, and Firebase versions.

@tgangso
Copy link

tgangso commented Nov 13, 2019

@jamesdaniels thanks for fixing it, I have been using both and have had some weird subtle issues, maybe this will fix it.

@johanchouquet
Copy link
Contributor Author

@johanchouquet I think ng 9 and Ivy will influence us moving forward but I don't foresee any breaks for the time being. I've started including basic ng 9 tests and I have a PR in which I've moved over to ngc building the library but haven't finished due to red tests. I'll be prioritizing that after 5.3. For risk of breaking I might just include that in version 6; which I foresee as 99% API compatible. I'll just be dropping compatibility with older Angular, Typescript, and Firebase versions.

Releaved to know that our code base would likely not be too much disturbed. Thanks a lot for the clarifications @jamesdaniels !

@matheo
Copy link

matheo commented Nov 14, 2019

Thanks a lot @jamesdaniels
I've been missing the 5.3 release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants