Skip to content

AngularFire breaking change between 5.1.3 and 5.2.0 #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LanderBeeuwsaert opened this issue Jun 17, 2019 · 7 comments
Closed

AngularFire breaking change between 5.1.3 and 5.2.0 #2115

LanderBeeuwsaert opened this issue Jun 17, 2019 · 7 comments

Comments

@LanderBeeuwsaert
Copy link

Hello,

This is an issue regarding a breaking change going from AngularFire 5.1.3 to 5.2.0 that I'm unsure that it is the intention.

See the closed issue here: firebase/firebase-js-sdk#1837 ; closed because of a request to re-open here.

Could of course be that this is intended behaviour but I wouldn't think so.

@N-Andronopoulos
Copy link

Same issue as me: #2124

@LanderBeeuwsaert
Copy link
Author

Glad I'm not alone haha

@N-Andronopoulos
Copy link

Just turn off aot and you're good to go till its resolved.

angular.json

{
      "aot": false,
      ...
      "buildOptimizer": false,
}

@LanderBeeuwsaert
Copy link
Author

ok cool. Yeah thanks, but that would affect our production environment too much then. So not an option for us.

@matheo
Copy link

matheo commented Jul 13, 2019

@jamesdaniels this issue got attention in the firebase-js-sdk repo, but here it remains without a solution :( I've spent most of my day today trying to figure out the build issue and I just got here...

@LanderBeeuwsaert please rename this ticket to "Production Build Fail" or "Blank Screen of Death" so others can reach this easier, and figure that the only solution is to not optimize the bundle and get a ton of additional Mb in our bundle.

@jburson
Copy link

jburson commented Jul 15, 2019

@jamesdaniels Version 5.2 should be rolled back unless a fix is coming very soon. This AOT bug is catastrophic and makes this version useless.

@matheo
Copy link

matheo commented Jul 16, 2019

Refs #2117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants