Skip to content

AngularFireAuthModule and AngularFireDatabaseModule add a lot to final javascript bundle size #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asgarli opened this issue Dec 21, 2017 · 3 comments

Comments

@asgarli
Copy link
Contributor

asgarli commented Dec 21, 2017

I've noticed that AngularFireAuthModule and AngularFireDatabaseModule add a lot to my final javascript bundle sizes, around 120kb and 200kb respectively. Is that expected behavior, or am I doing something wrong? I'm using latest Angular, so AOT is enabled.

Version info

Angular: 5.1.0

Firebase: 4.8.0

AngularFire: 5.0.0-rc.4

Other (e.g. Ionic/Cordova, Node, browser, operating system): Windows 10, NodeJS 8

How to reproduce these conditions

Steps to set up and reproduce

Create a sample Angular project and add AngularFireAuthModule and AngularFireDatabaseModule

Expected behavior

Smaller library sizes

Actual behavior

  • AngularFireDatabaseModule adds around 200kb to final output size
  • AngularFireAuthModule adds around 120kb to final output size
@asgarli
Copy link
Contributor Author

asgarli commented Dec 21, 2017

Might be because of firebase/firebase-js-sdk#332

@jamesdaniels
Copy link
Member

Yeah, this is upstream; we'll need the Firebase JS SDK to become more modular to allow the package size to be reduced further. There are conversations going on here but we don't have anything to announce yet.

@asgarli
Copy link
Contributor Author

asgarli commented Jul 25, 2018

Can we keep this bug open to track the upstream dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants