Skip to content

Commit cbc15e7

Browse files
committed
Bumping more things
1 parent 843c78e commit cbc15e7

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+450
-527
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
"karma-jasmine": "^2.0.1",
8686
"karma-jasmine-html-reporter": "^1.4.2",
8787
"ncp": "^2.0.0",
88-
"ng-packagr": "^5.3.0",
88+
"ng-packagr": "^9.0.0-0 || ^9.0.0",
8989
"pretty-size": "^2.0.0",
9090
"protractor": "3.0.0",
9191
"reflect-metadata": "0.1.2",

src/analytics/analytics.service.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ const SCREEN_INSTANCE_DELIMITER = '#';
2929

3030
const ANNOTATIONS = '__annotations__';
3131

32-
@Injectable()
32+
@Injectable({
33+
providedIn: 'root'
34+
})
3335
export class ScreenTrackingService implements OnDestroy {
3436

3537
private disposable: Subscription|undefined;
@@ -149,7 +151,9 @@ export class ScreenTrackingService implements OnDestroy {
149151

150152
}
151153

152-
@Injectable()
154+
@Injectable({
155+
providedIn: 'root'
156+
})
153157
export class UserTrackingService implements OnDestroy {
154158

155159
private disposable: Subscription|undefined;

src/analytics/analytics.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { TestBed, inject } from '@angular/core/testing';
22
import { FirebaseApp, FIREBASE_OPTIONS, AngularFireModule, FIREBASE_APP_NAME } from '@angular/fire';
3-
import { AngularFireAnalytics, AngularFireAnalyticsModule, COLLECTION_ENABLED, APP_VERSION, APP_NAME } from '@angular/fire/analytics';
3+
import { AngularFireAnalytics, AngularFireAnalyticsModule, COLLECTION_ENABLED, APP_VERSION, APP_NAME } from './public_api';
44
import { COMMON_CONFIG } from '../test-config';
55

66

src/analytics/analytics.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ const DATA_LAYER_NAME = 'dataLayer';
2323

2424
export interface AngularFireAnalytics extends PromiseProxy<analytics.Analytics> {};
2525

26-
@Injectable()
26+
@Injectable({
27+
providedIn: 'root'
28+
})
2729
export class AngularFireAnalytics {
2830

2931
private gtag: (...args: any[]) => void;
@@ -72,7 +74,6 @@ export class AngularFireAnalytics {
7274
if (debugModeEnabled) { this.updateConfig({ [DEBUG_MODE_KEY]: 1 }) }
7375

7476
const analytics = of(undefined).pipe(
75-
// @ts-ignore zapping in the UMD in the build script
7677
switchMap(() => zone.runOutsideAngular(() => import('firebase/analytics'))),
7778
catchError(err => err.message === 'Not supported' ? empty() : throwError(err) ),
7879
map(() => ɵfirebaseAppFactory(options, zone, nameOrConfig)),

src/analytics/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
{
2+
"$schema": "../node_modules/ng-packagr/package.schema.json",
23
"ngPackage": {
34
"lib": {
45
"umdModuleIds": {
5-
"firebase/app": "firebase"
6+
"firebase/app": "firebase",
7+
"tslib": "tslib"
68
},
79
"entryFile": "public_api.ts"
810
}

src/auth-guard/auth-guard.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { TestBed, inject } from '@angular/core/testing';
22
import { FirebaseApp, AngularFireModule } from '@angular/fire';
33
import { COMMON_CONFIG } from '../test-config';
44
import { AngularFireAuthModule } from '@angular/fire/auth';
5-
import { AngularFireAuthGuardModule, AngularFireAuthGuard } from '@angular/fire/auth-guard';
5+
import { AngularFireAuthGuardModule, AngularFireAuthGuard } from './public_api';
66
import { RouterModule, Router } from '@angular/router';
77
import { APP_BASE_HREF } from '@angular/common';
88

src/auth-guard/auth-guard.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ import { AngularFireAuth } from '@angular/fire/auth';
88
export type AuthPipeGenerator = (next: ActivatedRouteSnapshot, state: RouterStateSnapshot) => AuthPipe;
99
export type AuthPipe = UnaryFunction<Observable<User|null>, Observable<boolean|any[]>>;
1010

11-
@Injectable()
11+
@Injectable({
12+
providedIn: 'root'
13+
})
1214
export class AngularFireAuthGuard implements CanActivate {
1315

1416
constructor(private afAuth: AngularFireAuth, private router: Router) {}

src/auth-guard/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"$schema": "../../node_modules/ng-packagr/package.schema.json",
23
"ngPackage": {
34
"lib": {
45
"entryFile": "public_api.ts"

src/auth/auth.spec.ts

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { User } from 'firebase/app';
22
import { Observable, Subject } from 'rxjs'
33
import { TestBed, inject } from '@angular/core/testing';
44
import { FirebaseApp, FIREBASE_OPTIONS, AngularFireModule, FIREBASE_APP_NAME } from '@angular/fire';
5-
import { AngularFireAuth, AngularFireAuthModule } from '@angular/fire/auth';
5+
import { AngularFireAuth, AngularFireAuthModule } from './public_api';
66
import { COMMON_CONFIG } from '../test-config';
77
import { take, skip } from 'rxjs/operators';
88
import 'firebase/auth';
@@ -48,7 +48,7 @@ describe('AngularFireAuth', () => {
4848
});
4949

5050
afterEach(done => {
51-
afAuth.auth.app.delete().then(done, done.fail);
51+
afAuth.app.then(app => app.delete()).then(done, done.fail);
5252
});
5353

5454
describe('Zones', () => {
@@ -78,12 +78,8 @@ describe('AngularFireAuth', () => {
7878
expect(afAuth instanceof AngularFireAuth).toBe(true);
7979
});
8080

81-
it('should have the Firebase Auth instance', () => {
82-
expect(afAuth.auth).toBeDefined();
83-
});
84-
8581
it('should have an initialized Firebase app', () => {
86-
expect(afAuth.auth.app).toBeDefined();
82+
expect(afAuth.app).toBeDefined();
8783
});
8884

8985
it('should emit auth updates through authState', (done: any) => {
@@ -158,11 +154,12 @@ describe('AngularFireAuth with different app', () => {
158154
});
159155

160156
it('should have an initialized Firebase app', () => {
161-
expect(afAuth.auth.app).toBeDefined();
157+
expect(afAuth.app).toBeDefined();
162158
});
163159

164-
it('should have an initialized Firebase app instance member', () => {
165-
expect(afAuth.auth.app.name).toEqual(FIREBASE_APP_NAME_TOO);
160+
it('should have an initialized Firebase app instance member', async () => {
161+
const app = await afAuth.app;
162+
expect(app.name).toEqual(FIREBASE_APP_NAME_TOO);
166163
});
167164
});
168165

src/auth/auth.ts

Lines changed: 32 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
11
import { Injectable, Inject, Optional, NgZone, PLATFORM_ID } from '@angular/core';
22
import { Observable, of, from } from 'rxjs';
3-
import { switchMap } from 'rxjs/operators';
4-
import { FIREBASE_OPTIONS, FIREBASE_APP_NAME, FirebaseOptions, FirebaseAppConfig, FirebaseAuth, ɵfirebaseAppFactory, ɵFirebaseZoneScheduler } from '@angular/fire';
3+
import { switchMap, shareReplay, map } from 'rxjs/operators';
4+
import { FIREBASE_OPTIONS, FIREBASE_APP_NAME, FirebaseOptions, FirebaseAppConfig, FirebaseAuth, ɵfirebaseAppFactory, ɵFirebaseZoneScheduler, ɵrunOutsideAngular, PromiseProxy, ɵlazySDKProxy } from '@angular/fire';
55
import { User, auth } from 'firebase/app';
66

7-
@Injectable()
8-
export class AngularFireAuth {
7+
export interface AngularFireAuth extends PromiseProxy<auth.Auth> {};
98

10-
/**
11-
* Firebase Auth instance
12-
*/
13-
public readonly auth: FirebaseAuth;
9+
@Injectable({
10+
providedIn: 'root'
11+
})
12+
export class AngularFireAuth {
1413

1514
/**
1615
* Observable of authentication state; as of Firebase 4.0 this is only triggered via sign-in/out
@@ -41,37 +40,37 @@ export class AngularFireAuth {
4140
private zone: NgZone
4241
) {
4342
const scheduler = new ɵFirebaseZoneScheduler(zone, platformId);
44-
this.auth = zone.runOutsideAngular(() => {
45-
const app = ɵfirebaseAppFactory(options, zone, nameOrConfig);
46-
if (!app.auth) { throw "You must import 'firebase/auth' before using AngularFireAuth" }
47-
return app.auth();
48-
});
4943

50-
this.authState = scheduler.keepUnstableUntilFirst(
51-
scheduler.runOutsideAngular(
52-
new Observable(subscriber => {
53-
const unsubscribe = this.auth.onAuthStateChanged(subscriber);
54-
return { unsubscribe };
55-
})
56-
)
44+
const auth = of(undefined).pipe(
45+
switchMap(() => zone.runOutsideAngular(() => import('firebase/auth'))),
46+
map(() => ɵfirebaseAppFactory(options, zone, nameOrConfig)),
47+
map(app => app.auth()),
48+
ɵrunOutsideAngular(zone),
49+
shareReplay({ bufferSize: 1, refCount: false }),
50+
);
51+
52+
this.authState = auth.pipe(
53+
switchMap(auth => from(auth.onAuthStateChanged)),
54+
ɵrunOutsideAngular(zone),
55+
scheduler.keepUnstableUntilFirst.bind(scheduler),
56+
);
57+
58+
this.user = auth.pipe(
59+
switchMap(auth => from(auth.onIdTokenChanged)),
60+
ɵrunOutsideAngular(zone),
61+
scheduler.keepUnstableUntilFirst.bind(scheduler),
62+
);
63+
64+
this.idToken = this.user.pipe(
65+
switchMap(user => user ? from(user.getIdToken()) : of(null))
5766
);
5867

59-
this.user = scheduler.keepUnstableUntilFirst(
60-
scheduler.runOutsideAngular(
61-
new Observable(subscriber => {
62-
const unsubscribe = this.auth.onIdTokenChanged(subscriber);
63-
return { unsubscribe };
64-
})
65-
)
68+
this.idTokenResult = this.user.pipe(
69+
switchMap(user => user ? from(user.getIdTokenResult()) : of(null))
6670
);
6771

68-
this.idToken = this.user.pipe(switchMap(user => {
69-
return user ? from(user.getIdToken()) : of(null)
70-
}));
72+
return ɵlazySDKProxy(this, auth, zone);
7173

72-
this.idTokenResult = this.user.pipe(switchMap(user => {
73-
return user ? from(user.getIdTokenResult()) : of(null)
74-
}));
7574
}
7675

7776
}

src/auth/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"$schema": "../../node_modules/ng-packagr/package.schema.json",
23
"ngPackage": {
34
"lib": {
45
"entryFile": "public_api.ts"

src/core/angularfire2.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { TestBed, inject } from '@angular/core/testing';
22
import { PlatformRef, NgModule, CompilerFactory } from '@angular/core';
3-
import { FirebaseApp, AngularFireModule } from '@angular/fire';
3+
import { FirebaseApp, AngularFireModule } from './public_api';
44
import { Subscription } from 'rxjs';
55
import { COMMON_CONFIG } from '../test-config';
66
import { BrowserModule } from '@angular/platform-browser';

src/database-deprecated/database.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ import { FirebaseObjectObservable } from './firebase_object_observable';
77
import * as utils from './utils';
88
import { FirebaseDatabase, FirebaseOptions, FirebaseAppConfig, FIREBASE_OPTIONS, FIREBASE_APP_NAME, DATABASE_URL, ɵfirebaseAppFactory } from '@angular/fire';
99

10-
@Injectable()
10+
@Injectable({
11+
providedIn: 'root'
12+
})
1113
export class AngularFireDatabase {
1214

1315
/**

src/database-deprecated/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"$schema": "../../node_modules/ng-packagr/package.schema.json",
23
"ngPackage": {
34
"lib": {
45
"entryFile": "public_api.ts"

src/database/database.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { FirebaseApp, AngularFireModule, FIREBASE_OPTIONS, FIREBASE_APP_NAME } from '@angular/fire';
2-
import { AngularFireDatabase, AngularFireDatabaseModule, URL } from '@angular/fire/database';
2+
import { AngularFireDatabase, AngularFireDatabaseModule, URL } from './public_api';
33
import { TestBed, inject } from '@angular/core/testing';
44
import { COMMON_CONFIG } from '../test-config';
55
import { NgZone } from '@angular/core';

src/database/database.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ import { createListReference } from './list/create-reference';
55
import { createObjectReference } from './object/create-reference';
66
import { FirebaseDatabase, FirebaseOptions, FirebaseAppConfig, DATABASE_URL, FIREBASE_OPTIONS, FIREBASE_APP_NAME, ɵfirebaseAppFactory, ɵFirebaseZoneScheduler } from '@angular/fire';
77

8-
@Injectable()
8+
@Injectable({
9+
providedIn: 'root'
10+
})
911
export class AngularFireDatabase {
1012
public readonly database: FirebaseDatabase;
1113
public readonly scheduler: ɵFirebaseZoneScheduler;

src/database/list/audit-trail.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { DatabaseReference } from '../interfaces';
22
import { FirebaseApp, AngularFireModule } from '@angular/fire';
3-
import { AngularFireDatabase, AngularFireDatabaseModule, auditTrail, ChildEvent, URL } from '@angular/fire/database';
3+
import { AngularFireDatabase, AngularFireDatabaseModule, auditTrail, ChildEvent, URL } from '../public_api';
44
import { TestBed, inject } from '@angular/core/testing';
55
import { COMMON_CONFIG } from '../../test-config';
66
import { skip } from 'rxjs/operators';

src/database/list/changes.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { database } from 'firebase/app';
22
import { FirebaseApp, AngularFireModule } from '@angular/fire';
3-
import { AngularFireDatabase, AngularFireDatabaseModule, listChanges, URL } from '@angular/fire/database';
3+
import { AngularFireDatabase, AngularFireDatabaseModule, listChanges, URL } from '../public_api';
44
import { TestBed, inject } from '@angular/core/testing';
55
import { COMMON_CONFIG } from '../../test-config';
66
import { skip, take } from 'rxjs/operators';

src/database/list/snapshot-changes.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { database } from 'firebase/app';
22
import { FirebaseApp, AngularFireModule } from '@angular/fire';
3-
import { AngularFireDatabase, AngularFireDatabaseModule, snapshotChanges, ChildEvent, URL } from '@angular/fire/database';
3+
import { AngularFireDatabase, AngularFireDatabaseModule, snapshotChanges, ChildEvent, URL } from '../public_api';
44
import { TestBed, inject } from '@angular/core/testing';
55
import { COMMON_CONFIG } from '../../test-config';
66
import { BehaviorSubject } from 'rxjs';

src/database/list/state-changes.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { database } from 'firebase/app';
22
import { FirebaseApp, AngularFireModule } from '@angular/fire';
3-
import { AngularFireDatabase, AngularFireDatabaseModule, stateChanges, ChildEvent, URL } from '@angular/fire/database';
3+
import { AngularFireDatabase, AngularFireDatabaseModule, stateChanges, ChildEvent, URL } from '../public_api';
44
import { TestBed, inject } from '@angular/core/testing';
55
import { COMMON_CONFIG } from '../../test-config';
66
import { skip } from 'rxjs/operators';

src/database/observable/fromRef.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { DatabaseReference } from '../interfaces';
22
import { FirebaseApp, AngularFireModule } from '@angular/fire';
3-
import { AngularFireDatabase, AngularFireDatabaseModule, fromRef, URL } from '@angular/fire/database';
3+
import { AngularFireDatabase, AngularFireDatabaseModule, fromRef, URL } from '../public_api';
44
import { TestBed, inject } from '@angular/core/testing';
55
import { COMMON_CONFIG } from '../../test-config';
66
import { take } from 'rxjs/operators';

src/database/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"$schema": "../../node_modules/ng-packagr/package.schema.json",
23
"ngPackage": {
34
"lib": {
45
"umdModuleIds": {

src/firestore/collection-group/collection-group.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { FirebaseApp, AngularFireModule } from '@angular/fire';
2-
import { AngularFirestore, AngularFirestoreModule, AngularFirestoreDocument, AngularFirestoreCollectionGroup, SETTINGS } from '@angular/fire/firestore';
2+
import { AngularFirestore, AngularFirestoreModule, AngularFirestoreDocument, AngularFirestoreCollectionGroup, SETTINGS } from '../public_api';
33
import { QueryGroupFn, Query } from '../interfaces';
44
import { Observable, BehaviorSubject, Subscription } from 'rxjs';
55
import { skip, take, switchMap } from 'rxjs/operators';

src/firestore/firestore.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,9 @@ export function associateQuery(collectionRef: CollectionReference, queryFn = ref
8787
* }
8888
* }
8989
*/
90-
@Injectable()
90+
@Injectable({
91+
providedIn: 'root'
92+
})
9193
export class AngularFirestore {
9294
public readonly firestore: FirebaseFirestore;
9395
public readonly persistenceEnabled$: Observable<boolean>;

src/firestore/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"$schema": "../../node_modules/ng-packagr/package.schema.json",
23
"ngPackage": {
34
"lib": {
45
"entryFile": "public_api.ts"

src/functions/functions.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { TestBed, inject } from '@angular/core/testing';
22
import { FirebaseApp, FIREBASE_OPTIONS, AngularFireModule, FIREBASE_APP_NAME } from '@angular/fire';
3-
import { AngularFireFunctions, AngularFireFunctionsModule, REGION, ORIGIN } from '@angular/fire/functions';
3+
import { AngularFireFunctions, AngularFireFunctionsModule, REGION, ORIGIN } from './public_api';
44
import { COMMON_CONFIG } from '../test-config';
55
import 'firebase/functions';
66

@@ -31,7 +31,7 @@ describe('AngularFireFunctions', () => {
3131
});
3232

3333
it('should have the Firebase Functions instance', () => {
34-
expect(afFns.functions).toBeDefined();
34+
expect(afFns.useFunctionsEmulator).toBeDefined();
3535
});
3636

3737
});
@@ -73,7 +73,7 @@ describe('AngularFireFunctions with different app', () => {
7373
});
7474

7575
it('should have the Firebase Functions instance', () => {
76-
expect(afFns.functions).toBeDefined();
76+
expect(afFns.useFunctionsEmulator).toBeDefined();
7777
});
7878

7979
});

0 commit comments

Comments
 (0)