File tree Expand file tree Collapse file tree 2 files changed +6
-9
lines changed Expand file tree Collapse file tree 2 files changed +6
-9
lines changed Original file line number Diff line number Diff line change @@ -111,11 +111,6 @@ jobs:
111
111
- name : Yarn install
112
112
if : steps.node_modules_cache.outputs.cache-hit != 'true'
113
113
run : yarn install --frozen-lockfile --prefer-offline
114
- - name : Bump deps
115
- run : |
116
- yarn add firebase@${{ matrix.firebase }}
117
- yarn add firebase-tools@${{ matrix.firebaseTools }}
118
- yarn add rxjs@${{ matrix.rxjs }} --prefer-offline
119
114
- name : Firebase emulator cache
120
115
uses : actions/cache@v2
121
116
with :
@@ -128,15 +123,15 @@ jobs:
128
123
- name : Test Node
129
124
run : |
130
125
yarn build:jasmine
131
- yarn test:node-esm
126
+ yarn test:node
132
127
- name : Test browser
128
+ # only test on the default, maybe we should just make this a seperate test
133
129
if : matrix.os == 'ubuntu-latest' && matrix.node == '16'
134
130
run : yarn test:chrome-headless
135
131
- name : ng-build yarn install
136
132
run : |
137
133
cd ./test/ng-build
138
134
yarn --prefer-offline
139
- yarn add firebase@${{ matrix.firebase }}
140
135
- name : ng-build prerender
141
136
run : |
142
137
cd ./test/ng-build
@@ -213,7 +208,7 @@ jobs:
213
208
- name : Test Node
214
209
run : |
215
210
yarn build:jasmine
216
- yarn test:node-esm
211
+ yarn test:node
217
212
- name : Test browser
218
213
run : yarn test:chrome-headless
219
214
- name : ng-build yarn install
Original file line number Diff line number Diff line change @@ -630,7 +630,9 @@ describe('ng-add', () => {
630
630
project : PROJECT_NAME ,
631
631
prerender : false ,
632
632
} ) ) . toBeRejectedWith (
633
- new SchematicsException ( 'Error when parsing .firebaserc: Unexpected token I in JSON at position 0' )
633
+ parseInt ( process . versions . node , 10 ) >= 20 ?
634
+ new SchematicsException ( `Error when parsing .firebaserc: Unexpected token 'I', "I'm broken 😔" is not valid JSON.` ) :
635
+ new SchematicsException ( 'Error when parsing .firebaserc: Unexpected token I in JSON at position 0' )
634
636
) ;
635
637
} ) ;
636
638
You can’t perform that action at this time.
0 commit comments