Skip to content

Commit bffe8aa

Browse files
committed
fix(deps): scoped firebase packaging
1 parent dd8c824 commit bffe8aa

File tree

11 files changed

+130
-120
lines changed

11 files changed

+130
-120
lines changed

package.json

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angularfire2",
3-
"version": "5.0.0-rc.5.4-next",
3+
"version": "5.0.0-rc.5.6-next",
44
"description": "The official library of Firebase and Angular.",
55
"private": true,
66
"scripts": {
@@ -34,14 +34,18 @@
3434
"@angular/core": "^5.0.0",
3535
"@angular/platform-browser": "^5.0.0",
3636
"@angular/platform-browser-dynamic": "^5.0.0",
37-
"@firebase/app": "^0.1.5",
38-
"@firebase/app-types": "^0.1.0",
39-
"@firebase/auth-types": "^0.1.0",
40-
"@firebase/database-types": "^0.1.0",
41-
"@firebase/firestore-types": "^0.1.0",
42-
"@firebase/messaging-types": "^0.1.0",
43-
"@firebase/storage-types": "^0.1.0",
44-
"firebase": "^4.8.2-0",
37+
"@firebase/app": "^0.1.6",
38+
"@firebase/app-types": "^0.1.1",
39+
"@firebase/auth": "^0.3.2",
40+
"@firebase/auth-types": "^0.1.1",
41+
"@firebase/database": "^0.1.7",
42+
"@firebase/database-types": "^0.1.1",
43+
"@firebase/firestore": "^0.2.3",
44+
"@firebase/firestore-types": "^0.1.1",
45+
"@firebase/messaging-types": "^0.1.1",
46+
"@firebase/storage": "^0.1.6",
47+
"@firebase/storage-types": "^0.1.1",
48+
"firebase": "^4.8.2",
4549
"rxjs": "^5.5.4",
4650
"zone.js": "^0.8.0"
4751
},
@@ -78,6 +82,7 @@
7882
"rollup": "^0.35.11",
7983
"rollup-plugin-node-resolve": "^3.0.0",
8084
"rollup-watch": "^2.5.0",
85+
"shelljs": "^0.8.0",
8186
"systemjs": "^0.19.16",
8287
"systemjs-builder": "^0.15.7",
8388
"traceur": "0.0.96",

src/auth/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222
"@angular/core": "ANGULAR_VERSION",
2323
"@angular/platform-browser": "ANGULAR_VERSION",
2424
"@angular/platform-browser-dynamic": "ANGULAR_VERSION",
25-
"firebase": "FIREBASE_VERSION",
25+
"@firebase/app": "FIREBASE_APP_VERSION",
26+
"@firebase/auth": "FIREBASE_AUTH_VERSION",
2627
"rxjs": "RXJS_VERSION",
2728
"zone.js": "ZONEJS_VERSION"
2829
},

src/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"@angular/core": "ANGULAR_VERSION",
2222
"@angular/platform-browser": "ANGULAR_VERSION",
2323
"@angular/platform-browser-dynamic": "ANGULAR_VERSION",
24-
"firebase": "FIREBASE_VERSION",
24+
"@firebase/app": "FIREBASE_APP_VERSION",
2525
"rxjs": "RXJS_VERSION",
2626
"zone.js": "ZONEJS_VERSION"
2727
},

src/database-deprecated/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222
"@angular/core": "ANGULAR_VERSION",
2323
"@angular/platform-browser": "ANGULAR_VERSION",
2424
"@angular/platform-browser-dynamic": "ANGULAR_VERSION",
25-
"firebase": "FIREBASE_VERSION",
25+
"@firebase/app": "FIREBASE_APP_VERSION",
26+
"@firebase/database": "FIREBASE_DATABASE_VERSION",
2627
"rxjs": "RXJS_VERSION",
2728
"zone.js": "ZONEJS_VERSION"
2829
},

src/database/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222
"@angular/core": "ANGULAR_VERSION",
2323
"@angular/platform-browser": "ANGULAR_VERSION",
2424
"@angular/platform-browser-dynamic": "ANGULAR_VERSION",
25-
"firebase": "FIREBASE_VERSION",
25+
"@firebase/app": "FIREBASE_APP_VERSION",
26+
"@firebase/database": "FIREBASE_DATABASE_VERSION",
2627
"rxjs": "RXJS_VERSION",
2728
"zone.js": "ZONEJS_VERSION"
2829
},

src/firestore/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222
"@angular/core": "ANGULAR_VERSION",
2323
"@angular/platform-browser": "ANGULAR_VERSION",
2424
"@angular/platform-browser-dynamic": "ANGULAR_VERSION",
25-
"firebase": "FIREBASE_VERSION",
25+
"@firebase/app": "FIREBASE_APP_VERSION",
26+
"@firebase/firestore": "FIREBASE_FIRESTORE_VERSION",
2627
"rxjs": "RXJS_VERSION",
2728
"zone.js": "ZONEJS_VERSION"
2829
},

src/root.spec.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ export * from './packages-dist/database/list/state-changes.spec';
1313
export * from './packages-dist/database/list/audit-trail.spec';
1414
export * from './packages-dist/storage/storage.spec';
1515

16+
// // Since this a deprecated API, we run on it on manual tests only
17+
// // It needs a network connection to run which makes it flaky on Travis
1618
// export * from './packages-dist/database-deprecated/firebase_list_factory.spec';
1719
// export * from './packages-dist/database-deprecated/firebase_object_factory.spec';
1820
// export * from './packages-dist/database-deprecated/firebase_list_observable.spec';

src/storage/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222
"@angular/core": "ANGULAR_VERSION",
2323
"@angular/platform-browser": "ANGULAR_VERSION",
2424
"@angular/platform-browser-dynamic": "ANGULAR_VERSION",
25-
"firebase": "FIREBASE_VERSION",
25+
"@firebase/app": "FIREBASE_APP_VERSION",
26+
"@firebase/storage": "FIREBASE_STORAGE_VERSION",
2627
"rxjs": "RXJS_VERSION",
2728
"zone.js": "ZONEJS_VERSION"
2829
},

test/ng-build/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
const fs = require('fs');
22
const { spawn, spawnSync } = require('child_process');
3-
const ng5Pkg = require('./ng5/package.json');
3+
const ng5Pkg = require(`${__dirname}/ng5/package.json`);
44
const pkg = require('../../package.json');
55
const shell = require('shelljs');
66

tools/build.js

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ const GLOBALS = {
6464
'@firebase/database': 'firebase',
6565
'@firebase/firestore': 'firebase',
6666
'@firebase/storage': 'firebase',
67+
'@firebase/util': 'firebase',
68+
'@firebase/webchannel-wrapper': 'firebase',
6769
'rxjs/scheduler/queue': 'Rx.Scheduler',
6870
'@angular/core/testing': 'ng.core.testing',
6971
'angularfire2': 'angularfire2',
@@ -77,7 +79,11 @@ const GLOBALS = {
7779
// Map of dependency versions across all packages
7880
const VERSIONS = {
7981
ANGULAR_VERSION: pkg.dependencies['@angular/core'],
80-
FIREBASE_VERSION: pkg.dependencies['firebase'],
82+
FIREBASE_APP_VERSION: pkg.dependencies['@firebase/app'],
83+
FIREBASE_DATABASE_VERSION: pkg.dependencies['@firebase/database'],
84+
FIREBASE_FIRESTORE_VERSION: pkg.dependencies['@firebase/firestore'],
85+
FIREBASE_AUTH_VERSION: pkg.dependencies['@firebase/auth'],
86+
FIREBASE_STORAGE_VERSION: pkg.dependencies['@firebase/storage'],
8187
RXJS_VERSION: pkg.dependencies['rxjs'],
8288
ZONEJS_VERSION: pkg.dependencies['zone.js'],
8389
ANGULARFIRE2_VERSION: pkg.version,
@@ -120,6 +126,15 @@ const DEST_PKG_PATHS = {
120126
storage: `${process.cwd()}/dist/packages-dist/storage/package.json`
121127
};
122128

129+
const FIREBASE_FEATURE_MODULES = {
130+
app: `${process.cwd()}/node_modules/@firebase/app/dist/esm/index.js`,
131+
auth: `${process.cwd()}/node_modules/@firebase/auth/dist/auth.js`,
132+
database: `${process.cwd()}/node_modules/@firebase/database/dist/esm/index.js`,
133+
firestore: `${process.cwd()}/node_modules/@firebase/firestore/dist/esm/index.js`,
134+
storage: `${process.cwd()}/node_modules/@firebase/storage/dist/esm/index.js`,
135+
util: `${process.cwd()}/node_modules/@firebase/util/dist/esm/index.js`,
136+
};
137+
123138
// Constants for running typescript commands
124139
const TSC = 'node_modules/.bin/tsc';
125140
const NGC = 'node_modules/.bin/ngc';
@@ -154,6 +169,16 @@ function generateBundle(entry, { dest, globals, moduleName }) {
154169
});
155170
}
156171

172+
function createFirebaseBundles(featurePaths, globals) {
173+
return Object.keys(featurePaths).map(feature => {
174+
return generateBundle(featurePaths[feature], {
175+
dest: `${process.cwd()}/dist/bundles/${feature}.js`,
176+
globals,
177+
moduleName: `firebase.${feature}`
178+
});
179+
});
180+
}
181+
157182
/**
158183
* Create a UMD bundle given a module name.
159184
* @param {string} name

0 commit comments

Comments
 (0)