Skip to content

Commit 526e418

Browse files
committed
fix(FirebaseObservable): make add() method accept any type of input
Closes #47
1 parent 0f2e5cf commit 526e418

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

src/angularfire.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ describe('angularfire', () => {
3131
var nextSpy = jasmine.createSpy('next');
3232
var questions = af.list('list-of-questions');
3333
questions.subscribe(nextSpy);
34-
questions.add(['hello']);
35-
expect(nextSpy.calls.first().args[0][0].val()).toEqual(['hello']);
34+
questions.add('hello');
35+
expect(nextSpy.calls.first().args[0][0].val()).toEqual('hello');
3636
}));
3737
});
3838

src/utils/firebase_observable.spec.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import {Observer} from 'rxjs/Observer';
44
import 'rxjs/add/operator/map';
55
import * as Firebase from 'firebase';
66

7+
const rootUrl = 'ws://localhost.firebaseio.test:5000';
8+
79
describe('FirebaseObservable', () => {
810
it('should return an instance of FirebaseObservable when calling operators', () => {
911
var O:FirebaseObservable<number> = new FirebaseObservable((observer:Observer<number>) => {
@@ -23,7 +25,7 @@ describe('FirebaseObservable', () => {
2325

2426

2527
it('should call push on the underlying ref', () => {
26-
var fbref =new Firebase('ws://localhost.firebaseio.test:5000');
28+
var fbref = new Firebase(rootUrl);
2729
var pushSpy = spyOn(fbref, 'push');
2830
var O:FirebaseObservable<any> = new FirebaseObservable((observer:Observer<any>) => {
2931
}, fbref);
@@ -34,6 +36,14 @@ describe('FirebaseObservable', () => {
3436

3537
expect(pushSpy).toHaveBeenCalledWith(1);
3638
});
39+
40+
41+
it('should accept any type of value without compilation error', () => {
42+
var O:FirebaseObservable<any> = new FirebaseObservable((observer:Observer<any>) => {
43+
}, new Firebase(rootUrl));
44+
45+
O.add('foo');
46+
});
3747
});
3848
});
3949

src/utils/firebase_observable.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export class FirebaseObservable<T> extends Observable<T> {
1515
return observable;
1616
}
1717

18-
add(val:T):void {
18+
add(val:any):void {
1919
if(!this._ref) {
2020
// _ref gets created when the observable is subscribed
2121
throw new Error('No ref specified for this Observable!');

0 commit comments

Comments
 (0)