Drop the side-effect imports

Author: jamesdaniels

src/auth/auth.module.ts

@@ -1,8 +1,6 @@
 import { NgModule } from '@angular/core';
 import { AngularFireAuth } from './auth';
 
-import 'firebase/auth';
-
 @NgModule({
   providers: [ AngularFireAuth ]
 })

src/auth/auth.ts

@@ -43,6 +43,7 @@ export class AngularFireAuth {
     const scheduler = new ɵFirebaseZoneScheduler(zone, platformId);
     this.auth = zone.runOutsideAngular(() => {
       const app = ɵfirebaseAppFactory(options, zone, nameOrConfig);
+      if (!app.auth) { throw "You must import 'firebase/auth' before using AngularFireAuth" }
       return app.auth();
     });
 

src/core/firebase.app.module.ts

@@ -1,5 +1,6 @@
 import { InjectionToken, NgModule, Optional, NgZone } from '@angular/core';
 import { app, auth, database, messaging, storage, firestore, functions, analytics, performance, remoteConfig } from 'firebase/app';
+
 // @ts-ignore (https://github.com/firebase/firebase-js-sdk/pull/1206)
 import firebase from 'firebase/app'; // once fixed can pull in as "default as firebase" above
 

src/database-deprecated/database.module.ts

@@ -1,6 +1,5 @@
 import { NgModule } from '@angular/core';
 import { AngularFireDatabase } from './database';
-import 'firebase/database';
 
 @NgModule({
   providers: [ AngularFireDatabase ]

src/database-deprecated/database.ts

@@ -23,6 +23,7 @@ export class AngularFireDatabase {
   ) {
     this.database = zone.runOutsideAngular(() => {
       const app = ɵfirebaseAppFactory(options, zone, nameOrConfig);
+      if (!app.database) { throw "You must import 'firebase/database' before using AngularFireDatabase" }
       return app.database(databaseURL || undefined);
     });
   }

src/database/database.module.ts

@@ -1,8 +1,6 @@
 import { NgModule } from '@angular/core';
 import { AngularFireDatabase } from './database';
 
-import 'firebase/database';
-
 @NgModule({
   providers: [ AngularFireDatabase ]
 })

src/database/database.ts

@@ -20,6 +20,7 @@ export class AngularFireDatabase {
     this.scheduler = new ɵFirebaseZoneScheduler(zone, platformId);
     this.database = zone.runOutsideAngular(() => {
       const app = ɵfirebaseAppFactory(options, zone, nameOrConfig);
+      if (!app.database) { throw "You must import 'firebase/database' before using AngularFireDatabase" }
       return app.database(databaseURL || undefined);
     });
   }

src/firestore/firestore.module.ts

@@ -2,8 +2,6 @@ import { ModuleWithProviders, NgModule } from '@angular/core';
 import { PersistenceSettings } from './interfaces';
 import { AngularFirestore, ENABLE_PERSISTENCE, PERSISTENCE_SETTINGS } from './firestore';
 
-import 'firebase/firestore';
-
 @NgModule({
   providers: [ AngularFirestore ]
 })

src/firestore/firestore.ts

@@ -111,6 +111,7 @@ export class AngularFirestore {
     this.scheduler = new ɵFirebaseZoneScheduler(zone, platformId);
     this.firestore = zone.runOutsideAngular(() => {
       const app = ɵfirebaseAppFactory(options, zone, nameOrConfig);
+      if (!app.firestore) { throw "You must import 'firebase/firestore' before using AngularFirestore" }
       const firestore = app.firestore();
       if (settings) { firestore.settings(settings) }
       return firestore;

src/functions/functions.module.ts

@@ -1,6 +1,5 @@
 import { NgModule } from '@angular/core';
 import { AngularFireFunctions } from './functions';
-import 'firebase/functions'
 
 @NgModule({
   providers: [ AngularFireFunctions ]

src/functions/functions.ts

@@ -29,6 +29,7 @@ export class AngularFireFunctions {
 
     this.functions = zone.runOutsideAngular(() => {
       const app = ɵfirebaseAppFactory(options, zone, nameOrConfig);
+      if (!app.functions) { throw "You must import 'firebase/functions' before using AngularFireFunctions" }
       return app.functions(region || undefined);
     });
 

src/storage/storage.module.ts

@@ -1,6 +1,5 @@
 import { NgModule } from '@angular/core';
 import { AngularFireStorage } from './storage';
-import 'firebase/storage';
 
 @NgModule({
   providers: [ AngularFireStorage ]

src/storage/storage.ts

@@ -28,6 +28,7 @@ export class AngularFireStorage {
     this.scheduler = new ɵFirebaseZoneScheduler(zone, platformId);
     this.storage = zone.runOutsideAngular(() => {
       const app = ɵfirebaseAppFactory(options, zone, nameOrConfig);
+      if (!app.storage) { throw "You must import 'firebase/storage' before using AngularFireStorage" }
       return app.storage(storageBucket || undefined);
     });
   }