Skip to content

Commit 232b1a0

Browse files
fabien0102davideast
authored andcommitted
build(firebase): set firebase as peer dependency
Avoid incompatibility with project firebase. Fixes #623
1 parent ce3de04 commit 232b1a0

File tree

2 files changed

+2
-15
lines changed

2 files changed

+2
-15
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"@angular/platform-browser": "^2.0.0",
4242
"@angular/platform-browser-dynamic": "^2.0.0",
4343
"@types/jasmine": "^2.5.36",
44-
"firebase": "3.3.0",
44+
"firebase": "^3.0.0",
4545
"rxjs": "5.0.0-beta.12"
4646
},
4747
"devDependencies": {

tools/rewrite-published-package.js

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,7 @@ var srcPackage = require('../package.json');
99
delete srcPackage.scripts;
1010

1111
var peerDependencies = Object.assign({}, srcPackage.dependencies);
12-
// See note about including firebase as dependency
13-
delete peerDependencies.firebase;
1412

15-
var outPackage = Object.assign({}, srcPackage, {
16-
peerDependencies,
17-
dependencies: {
18-
/**
19-
* Firebase SDK should be a dependency since it's not required that
20-
* projects will install/use the SDK directly. And since Firebase uses
21-
* semver, the version restriction is more permissive. This means if the user
22-
* has installed Firebase already, npm is more likely to find a matching version.
23-
**/
24-
firebase: srcPackage.dependencies.firebase
25-
}
26-
});
13+
var outPackage = Object.assign({}, srcPackage, { peerDependencies });
2714

2815
fs.writeFileSync('./dist/package.json', JSON.stringify(outPackage, null, 2));

0 commit comments

Comments
 (0)