Skip to content

Tutorial "The Application Shell" is missing npm install part #23325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SetTrend opened this issue Apr 11, 2018 · 6 comments
Closed

Tutorial "The Application Shell" is missing npm install part #23325

SetTrend opened this issue Apr 11, 2018 · 6 comments
Milestone

Comments

@SetTrend
Copy link

SetTrend commented Apr 11, 2018

The tutorial page "The Application Shell" is missing information about the fact that the user needs to manually download corresponding npm packages after an Angular web application has been created.

There are so many questions out there, e.g. on StackOverflow, of concerned programmers wondering why any ng command (except for ng --version they issue fails.

So I'd like to suggest to amend the tutorial to include the npm install command from

## Serve the application

Go to the project directory and launch the application.

<code-example language="sh" class="code-shell">
  cd angular-tour-of-heroes
  ng serve --open
</code-example>

to

## Serve the application

Go to the project directory, install Angular's npm packages and launch the application.

<code-example language="sh" class="code-shell">
  cd angular-tour-of-heroes
  npm install
  ng serve --open
</code-example>
@trevor-hackett
Copy link

trevor-hackett commented Apr 12, 2018

In the "Create a new application" section it does say to run ng new angular-tour-of-heroes. That command runs npm install for you. The extra npm install that you're suggesting is redundant and won't help in this scenario.

@SetTrend
Copy link
Author

Strange .. Apparently it doesn't always do that.

@SetTrend
Copy link
Author

How are chances that option like --routing, --skip-commit, --skip-git, --skip-install, --skip-tests have influence on the initial creation of the npm packages?

The documentation isn't clear about the repercussions of these options.

angular/angular-cli#10296

@ngbot ngbot bot added this to the needsTriage milestone Apr 12, 2018
@IgorMinar
Copy link
Contributor

if you ng new my-project --skip-install then npm install won't be invoked.

@SetTrend
Copy link
Author

SetTrend commented Apr 18, 2018

Ah, I see. Thanks for enlightening me!

I will close this issue. Though, I feel that the documentation should be enhanced on options, then new and occasional programmers can quickly grasp the implications of any of the CLI options.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants