From b1b9a9044e467aaa15589a9bbcd6ec9fc3bc3bec Mon Sep 17 00:00:00 2001 From: Georgios Kalpakas Date: Mon, 13 Oct 2014 17:27:45 +0300 Subject: [PATCH] test(currencyFilter): fix disambiguous locator warning in e2e tests The e2e tests for the `currencyFilter` issued the following warnings: > warning: more than one element found for locator by.binding("amount | currency:"USD$"") This commit removes the warnings by locating the elements by ID and not by binding. --- src/ng/filter/filters.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/ng/filter/filters.js b/src/ng/filter/filters.js index b6a984187c42..61f07c1b6f9a 100644 --- a/src/ng/filter/filters.js +++ b/src/ng/filter/filters.js @@ -27,15 +27,15 @@

default currency symbol ($): {{amount | currency}}
- custom currency identifier (USD$): {{amount | currency:"USD$"}} - no fractions (0): {{amount | currency:"USD$":0}} + custom currency identifier (USD$): {{amount | currency:"USD$"}} + no fractions (0): {{amount | currency:"USD$":0}}
it('should init with 1234.56', function() { expect(element(by.id('currency-default')).getText()).toBe('$1,234.56'); - expect(element(by.binding('amount | currency:"USD$"')).getText()).toBe('USD$1,234.56'); - expect(element(by.binding('amount | currency:"USD$":0')).getText()).toBe('USD$1,235'); + expect(element(by.id('currency-custom')).getText()).toBe('USD$1,234.56'); + expect(element(by.id('currency-no-fractions')).getText()).toBe('USD$1,235'); }); it('should update', function() { if (browser.params.browser == 'safari') { @@ -46,8 +46,8 @@ element(by.model('amount')).clear(); element(by.model('amount')).sendKeys('-1234'); expect(element(by.id('currency-default')).getText()).toBe('($1,234.00)'); - expect(element(by.binding('amount | currency:"USD$"')).getText()).toBe('(USD$1,234.00)'); - expect(element(by.binding('amount | currency:"USD$":0')).getText()).toBe('(USD$1,234)'); + expect(element(by.id('currency-custom')).getText()).toBe('(USD$1,234.00)'); + expect(element(by.id('currency-no-fractions')).getText()).toBe('(USD$1,234)'); });