diff --git a/src/ng/directive/select.js b/src/ng/directive/select.js
index 5c9a43118164..d1f275a1ba6c 100644
--- a/src/ng/directive/select.js
+++ b/src/ng/directive/select.js
@@ -611,6 +611,7 @@ var selectDirective = ['$compile', '$parse', function($compile, $parse) {
id: option.id,
selected: option.selected
});
+ selectCtrl.addOption(option.label, element);
if (lastElement) {
lastElement.after(element);
} else {
@@ -622,7 +623,9 @@ var selectDirective = ['$compile', '$parse', function($compile, $parse) {
// remove any excessive OPTIONs in a group
index++; // increment since the existingOptions[0] is parent element not OPTION
while(existingOptions.length > index) {
- existingOptions.pop().element.remove();
+ option = existingOptions.pop();
+ selectCtrl.removeOption(option.label);
+ option.element.remove();
}
}
// remove any excessive OPTGROUPs from select
diff --git a/test/ng/directive/selectSpec.js b/test/ng/directive/selectSpec.js
index e896dc05836d..3a93fb50304e 100644
--- a/test/ng/directive/selectSpec.js
+++ b/test/ng/directive/selectSpec.js
@@ -405,6 +405,39 @@ describe('select', function() {
expect(element).toEqualSelect(['? string:r2d2 ?']);
expect(scope.robot).toBe('r2d2');
});
+
+ describe('selectController.hasOption', function() {
+ it('should return true for options added via ngOptions', function() {
+ scope.robots = [
+ {key: 1, value: 'c3p0'},
+ {key: 2, value: 'r2d2'}
+ ];
+ scope.robot = 'r2d2';
+
+ compile('');
+
+ var selectCtrl = element.data().$selectController;
+
+ expect(selectCtrl.hasOption('c3p0')).toBe(true);
+ expect(selectCtrl.hasOption('r2d2')).toBe(true);
+
+ scope.$apply(function() {
+ scope.robots.pop();
+ });
+
+ expect(selectCtrl.hasOption('c3p0')).toBe(true);
+ expect(selectCtrl.hasOption('r2d2')).toBe(false);
+
+ scope.$apply(function() {
+ scope.robots.push({key: 2, value: 'r2d2'});
+ });
+
+ expect(selectCtrl.hasOption('c3p0')).toBe(true);
+ expect(selectCtrl.hasOption('r2d2')).toBe(true);
+ });
+ });
});
});
});
@@ -481,6 +514,39 @@ describe('select', function() {
expect(element).toBeValid();
expect(element).toBeDirty();
});
+
+ describe('selectController.hasOption', function() {
+ it('should return true for options added via ngOptions', function() {
+ scope.robots = [
+ {key: 1, value: 'c3p0'},
+ {key: 2, value: 'r2d2'}
+ ];
+ scope.robot = 'r2d2';
+
+ compile('');
+
+ var selectCtrl = element.data().$selectController;
+
+ expect(selectCtrl.hasOption('c3p0')).toBe(true);
+ expect(selectCtrl.hasOption('r2d2')).toBe(true);
+
+ scope.$apply(function() {
+ scope.robots.pop();
+ });
+
+ expect(selectCtrl.hasOption('c3p0')).toBe(true);
+ expect(selectCtrl.hasOption('r2d2')).toBe(false);
+
+ scope.$apply(function() {
+ scope.robots.push({key: 2, value: 'r2d2'});
+ });
+
+ expect(selectCtrl.hasOption('c3p0')).toBe(true);
+ expect(selectCtrl.hasOption('r2d2')).toBe(true);
+ });
+ });
});