From e6e219247ac79f3b0f72ec2b5df191f4a24ad02b Mon Sep 17 00:00:00 2001 From: Daniel Aden Date: Fri, 1 Nov 2013 22:49:43 -0700 Subject: [PATCH 1/2] Adding Closure externs for angular.$q.Promise.finally. --- closure/angular.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/closure/angular.js b/closure/angular.js index 0103c555ebfa..32e0512bd28e 100644 --- a/closure/angular.js +++ b/closure/angular.js @@ -1605,6 +1605,12 @@ angular.$q.Promise; */ angular.$q.Promise.then = function(successCallback, opt_errorCallback) {}; +/** + * @param {?function(?)} callback + * @return {angular.$q.Promise} + */ +angular.$q.Promise.finally = function(callback) {}; + /****************************************************************************** * $route Service *****************************************************************************/ From 8ce47d6de2a76a7c61ae936684ae8b6c2961106f Mon Sep 17 00:00:00 2001 From: Daniel Aden Date: Fri, 1 Nov 2013 22:49:43 -0700 Subject: [PATCH 2/2] feat(Angular.js): Add Closure externs for angular.$q.Promise.finally --- closure/angular.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/closure/angular.js b/closure/angular.js index 0103c555ebfa..32e0512bd28e 100644 --- a/closure/angular.js +++ b/closure/angular.js @@ -1605,6 +1605,12 @@ angular.$q.Promise; */ angular.$q.Promise.then = function(successCallback, opt_errorCallback) {}; +/** + * @param {?function(?)} callback + * @return {angular.$q.Promise} + */ +angular.$q.Promise.finally = function(callback) {}; + /****************************************************************************** * $route Service *****************************************************************************/