From d07172fb6e66cb7b69c3db93151e38c9f7d630bc Mon Sep 17 00:00:00 2001
From: Gonzalo Ruiz de Villa <gonzalo.ruizdevilla@adesis.com>
Date: Wed, 1 May 2013 01:19:44 +0200
Subject: [PATCH 1/2] fix(ngRepeat): correctly iterate over array-like objects

Check if the object is array-like to iterate over it like it's done with arrays.

Closes #2546
---
 src/ng/directive/ngRepeat.js      |  2 +-
 test/ng/directive/ngRepeatSpec.js | 20 ++++++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/src/ng/directive/ngRepeat.js b/src/ng/directive/ngRepeat.js
index a7d558957d2d..0fd53c2f6657 100644
--- a/src/ng/directive/ngRepeat.js
+++ b/src/ng/directive/ngRepeat.js
@@ -212,7 +212,7 @@ var ngRepeatDirective = ['$parse', '$animator', function($parse, $animator) {
               nextBlockOrder = [];
 
 
-          if (isArray(collection)) {
+          if (isArrayLike(collection)) {
             collectionKeys = collection;
           } else {
             // if object, extract keys, sort them and use to determine order of iteration over obj props
diff --git a/test/ng/directive/ngRepeatSpec.js b/test/ng/directive/ngRepeatSpec.js
index 4372f57ab424..471bf4710380 100644
--- a/test/ng/directive/ngRepeatSpec.js
+++ b/test/ng/directive/ngRepeatSpec.js
@@ -55,6 +55,26 @@ describe('ngRepeat', function() {
   });
 
 
+  it('should iterate over an array-like object', function() {
+    element = $compile(
+      '<ul>' +
+        '<li ng-repeat="item in items">{{item.name}};</li>' +
+      '</ul>')(scope);
+
+    document.body.innerHTML = "<p>" +
+                                      "<a name='x'>a</a>" +
+                                      "<a name='y'>b</a>" +
+                                      "<a name='x'>c</a>" +
+                                    "</p>";
+
+    var htmlCollection = document.getElementsByTagName('a');
+    scope.items = htmlCollection;
+    scope.$digest();
+    expect(element.find('li').length).toEqual(3);
+    expect(element.text()).toEqual('x;y;x;');
+  });
+
+
   it('should iterate over on object/map', function() {
     element = $compile(
       '<ul>' +

From b0c0a645eb4eee8cb381d751c61072302ff9534e Mon Sep 17 00:00:00 2001
From: Gonzalo Ruiz de Villa <gonzalo.ruizdevilla@adesis.com>
Date: Thu, 2 May 2013 13:05:22 +0200
Subject: [PATCH 2/2] fix($rootScope) $watchCollection correctly handles
 arrayLike objects

---
 src/ng/rootScope.js      |  2 +-
 test/ng/rootScopeSpec.js | 17 +++++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/ng/rootScope.js b/src/ng/rootScope.js
index 10b31dd101b1..0892843da019 100644
--- a/src/ng/rootScope.js
+++ b/src/ng/rootScope.js
@@ -376,7 +376,7 @@ function $RootScopeProvider(){
               oldValue = newValue;
               changeDetected++;
             }
-          } else if (isArray(newValue)) {
+          } else if (isArrayLike(newValue)) {
             if (oldValue !== internalArray) {
               // we are transitioning from something which was not an array into array.
               oldValue = internalArray;
diff --git a/test/ng/rootScopeSpec.js b/test/ng/rootScopeSpec.js
index cd8d41099e95..cac7c16017dc 100644
--- a/test/ng/rootScopeSpec.js
+++ b/test/ng/rootScopeSpec.js
@@ -463,6 +463,23 @@ describe('Scope', function() {
           $rootScope.$digest();
           expect(log).toEqual([ '[{},[]]' ]);
         });
+
+        it('should watch array-like objects like arrays', function () {
+          var arrayLikelog = [];
+          $rootScope.$watchCollection('arrayLikeObject', function logger(obj) {
+            forEach(obj, function (element){
+              arrayLikelog.push(element.name);
+            })
+          });
+          document.body.innerHTML = "<p>" +
+                                      "<a name='x'>a</a>" +
+                                      "<a name='y'>b</a>" +
+                                    "</p>";
+
+          $rootScope.arrayLikeObject =  document.getElementsByTagName('a')
+          $rootScope.$digest();
+          expect(arrayLikelog).toEqual(['x', 'y']);
+        });
       });