From fe3dd0ae66c33d4ac24ecb4c4e88bec4f7d16c3b Mon Sep 17 00:00:00 2001 From: jugglinmike Date: Tue, 21 Nov 2017 13:30:06 -0500 Subject: [PATCH 1/3] docs(ngNonBindable): Document effect on attributes The phrase "contents of the current DOM element" may be interpreted either as inclusive of the DOM element's attributes or as exclusive of the attributes. This situation concerns markup such as:
In practice, AngularJS does not compile or bind attribute values for elements which specify the `ng-non-bindable` directive. Extend the documentation to definitely describe this behavior. --- src/ng/directive/ngNonBindable.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ng/directive/ngNonBindable.js b/src/ng/directive/ngNonBindable.js index cab3db9bd648..e776d9d14b77 100644 --- a/src/ng/directive/ngNonBindable.js +++ b/src/ng/directive/ngNonBindable.js @@ -9,9 +9,10 @@ * * @description * The `ngNonBindable` directive tells AngularJS not to compile or bind the contents of the current - * DOM element. This is useful if the element contains what appears to be AngularJS directives and - * bindings but which should be ignored by AngularJS. This could be the case if you have a site that - * displays snippets of code, for instance. + * DOM element (including the attributes of the element itself). This is useful if the element + * contains what appears to be AngularJS directives and bindings but which should be ignored by + * AngularJS. This could be the case if you have a site that displays snippets of code, for + * instance. * * @example * In this example there are two locations where a simple interpolation binding (`{{}}`) is present, From b34e8fc39679bdfb327bf1f07a948487d12b0e12 Mon Sep 17 00:00:00 2001 From: jugglinmike Date: Wed, 22 Nov 2017 08:16:39 -0500 Subject: [PATCH 2/3] fixup! docs(ngNonBindable): Document effect on attributes --- src/ng/directive/ngNonBindable.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/ng/directive/ngNonBindable.js b/src/ng/directive/ngNonBindable.js index e776d9d14b77..4fe78c73b44c 100644 --- a/src/ng/directive/ngNonBindable.js +++ b/src/ng/directive/ngNonBindable.js @@ -9,10 +9,13 @@ * * @description * The `ngNonBindable` directive tells AngularJS not to compile or bind the contents of the current - * DOM element (including the attributes of the element itself). This is useful if the element - * contains what appears to be AngularJS directives and bindings but which should be ignored by - * AngularJS. This could be the case if you have a site that displays snippets of code, for - * instance. + * DOM element.AngularJS will generally ignore each attribute of the element itself. Attributes will + * *not* be ignored if they are part of a directive that has a higher priority than that of the + * `ngNonBindable` directive. + * + * This is useful if the element contains what appears to be AngularJS directives and bindings but + * which should be ignored by AngularJS. This could be the case if you have a site that displays + * snippets of code, for instance. * * @example * In this example there are two locations where a simple interpolation binding (`{{}}`) is present, From ad5f77c7da4b524905d95c6ddcab1c8bc91915a4 Mon Sep 17 00:00:00 2001 From: jugglinmike Date: Fri, 24 Nov 2017 11:27:04 -0500 Subject: [PATCH 3/3] fixup! docs(ngNonBindable): Document effect on attributes --- src/ng/directive/ngNonBindable.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/ng/directive/ngNonBindable.js b/src/ng/directive/ngNonBindable.js index 4fe78c73b44c..fed7683af711 100644 --- a/src/ng/directive/ngNonBindable.js +++ b/src/ng/directive/ngNonBindable.js @@ -9,13 +9,10 @@ * * @description * The `ngNonBindable` directive tells AngularJS not to compile or bind the contents of the current - * DOM element.AngularJS will generally ignore each attribute of the element itself. Attributes will - * *not* be ignored if they are part of a directive that has a higher priority than that of the - * `ngNonBindable` directive. - * - * This is useful if the element contains what appears to be AngularJS directives and bindings but - * which should be ignored by AngularJS. This could be the case if you have a site that displays - * snippets of code, for instance. + * DOM element, including directives on the element itself that have a lower priority than + * `ngNonBindable`. This is useful if the element contains what appears to be AngularJS directives + * and bindings but which should be ignored by AngularJS. This could be the case if you have a site + * that displays snippets of code, for instance. * * @example * In this example there are two locations where a simple interpolation binding (`{{}}`) is present,