From 9f26eea3aa68d36e38394e0268c04ffcfd99deb0 Mon Sep 17 00:00:00 2001 From: Aaron Brewer Date: Fri, 9 Dec 2016 15:27:03 -0500 Subject: [PATCH 1/2] docs(ngMessageExp): Better description Old description was copied over from ngMessage. --- src/ngMessages/messages.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/ngMessages/messages.js b/src/ngMessages/messages.js index f15b1099a505..776d1246e4c3 100644 --- a/src/ngMessages/messages.js +++ b/src/ngMessages/messages.js @@ -629,10 +629,8 @@ angular.module('ngMessages', [], function initAngularHelpers() { * @scope * * @description - * `ngMessageExp` is a directive with the purpose to show and hide a particular message. - * For `ngMessageExp` to operate, a parent `ngMessages` directive on a parent DOM element - * must be situated since it determines which messages are visible based on the state - * of the provided key/value map that `ngMessages` listens on. + * `ngMessageExp` is the same as {@link module:ngMessage `ngMessage`} but instead + * of a DOM attribute, accepts an expression to be evaluated for the message key. * * @usage * ```html From 7b79a7b6829a5b090aded12e94241be7cc678267 Mon Sep 17 00:00:00 2001 From: Aaron Brewer Date: Sat, 10 Dec 2016 18:18:58 -0500 Subject: [PATCH 2/2] Updating changes per feedback link needs to point to the ngMessage directive, and DOM attribute isn't clear enough --- src/ngMessages/messages.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ngMessages/messages.js b/src/ngMessages/messages.js index 776d1246e4c3..6ce5b0625564 100644 --- a/src/ngMessages/messages.js +++ b/src/ngMessages/messages.js @@ -629,8 +629,8 @@ angular.module('ngMessages', [], function initAngularHelpers() { * @scope * * @description - * `ngMessageExp` is the same as {@link module:ngMessage `ngMessage`} but instead - * of a DOM attribute, accepts an expression to be evaluated for the message key. + * `ngMessageExp` is the same as {@link directive:ngMessage `ngMessage`} but instead + * of a static value, accepts an expression to be evaluated for the message key. * * @usage * ```html