From 50c2902b09237eb23bb028c3ffe1230d7b2cf8f9 Mon Sep 17 00:00:00 2001 From: David Souther Date: Tue, 23 Dec 2014 10:10:39 -0500 Subject: [PATCH] fix($exceptionHandlerProvider): call `inject()` to run tests In the current angular-mocksSpec, the tests for $exceptionHandlerProvider call `module` to run tests on `$exceptionHandlerProvider.mode()`, but do not call `inject()` to pump the module definitions. --- test/ngMock/angular-mocksSpec.js | 35 +++++++++++++++++++------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/test/ngMock/angular-mocksSpec.js b/test/ngMock/angular-mocksSpec.js index d9773b42904b..4b09cbd84719 100644 --- a/test/ngMock/angular-mocksSpec.js +++ b/test/ngMock/angular-mocksSpec.js @@ -592,22 +592,29 @@ describe('ngMock', function() { })); - it('should log exceptions', module(function($exceptionHandlerProvider) { - $exceptionHandlerProvider.mode('log'); - var $exceptionHandler = $exceptionHandlerProvider.$get(); - $exceptionHandler('MyError'); - expect($exceptionHandler.errors).toEqual(['MyError']); - - $exceptionHandler('MyError', 'comment'); - expect($exceptionHandler.errors[1]).toEqual(['MyError', 'comment']); - })); + it('should log exceptions', function() { + module(function($exceptionHandlerProvider) { + $exceptionHandlerProvider.mode('log'); + }); + inject(function($exceptionHandler) { + $exceptionHandler('MyError'); + expect($exceptionHandler.errors).toEqual(['MyError']); + $exceptionHandler('MyError', 'comment'); + expect($exceptionHandler.errors[1]).toEqual(['MyError', 'comment']); + }); + }); + + it('should throw on wrong argument', function() { + module(function($exceptionHandlerProvider) { + expect(function() { + $exceptionHandlerProvider.mode('XXX'); + }).toThrow("Unknown mode 'XXX', only 'log'/'rethrow' modes are allowed!"); + }); + + inject(); // Trigger the tests in `module` + }); - it('should throw on wrong argument', module(function($exceptionHandlerProvider) { - expect(function() { - $exceptionHandlerProvider.mode('XXX'); - }).toThrow("Unknown mode 'XXX', only 'log'/'rethrow' modes are allowed!"); - })); });