From 35e516ae877c6177d13bd37e2d3c68b7476be083 Mon Sep 17 00:00:00 2001 From: Shahar Talmi Date: Sat, 20 Dec 2014 18:04:28 +0200 Subject: [PATCH] refactor(limitTo): no need for all those checks if we use slice --- src/ng/filter/limitTo.js | 31 ++++--------------------------- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/src/ng/filter/limitTo.js b/src/ng/filter/limitTo.js index 6937ce6022d8..f85069944cf8 100644 --- a/src/ng/filter/limitTo.js +++ b/src/ng/filter/limitTo.js @@ -97,34 +97,11 @@ function limitToFilter() { limit = int(limit); } - if (isString(input)) { - //NaN check on limit - if (limit) { - return limit >= 0 ? input.slice(0, limit) : input.slice(limit, input.length); - } else { - return ""; - } - } - - var i, n; - - // if abs(limit) exceeds maximum length, trim it - if (limit > input.length) - limit = input.length; - else if (limit < -input.length) - limit = -input.length; - - if (limit > 0) { - i = 0; - n = limit; + //NaN check on limit + if (limit) { + return limit > 0 ? input.slice(0, limit) : input.slice(limit); } else { - // zero and NaN check on limit - return empty array - if (!limit) return []; - - i = input.length + limit; - n = input.length; + return isString(input) ? "" : []; } - - return input.slice(i, n); }; }