Strict mode at file level in locale files

[ArturDorochowicz]

Strict mode is specified at file level in Angular locale files, e.g. see: angular-locale_aa-dj.js.

This makes them infeasible for concatenation with other scripts that may not be strict mode compliant.

Please remove strict mode from file level there. As far as I see this is a matter of applying some changes to i18n/src/closureI18nExtractor.js

[btford]

It's better to wrap the file in an immediately invoked function expression:

(function () {
  /* file contents here */
}())

I don't think Angular should be making changes to accommodate brittle build systems.

[ArturDorochowicz]

Reconsider this, please.

1. Of course it's better to wrap the contents in IIF. It's even better to fix the problem once and for all - at the source, instead of requiring consumers to repeatedly deal with this problem.
2. For some reason none of the other Angular deliverables require this "workaround". How about bringing locale in line with the rest of Angular?
3. This violates a rather clear recommendation of not using global strict mode.

[gkalpak]

@btford: Since this seems to be such a trivial change (either wrap the contents in an IIFE or move the 'use strict' inside of the config function), is there any reason why Angular wouldn't want something like this (e.g. is it going to create problems elsewhere I don't know about) ?

If nothing else it is good coding style not to have global strict mode, isn't it ?