Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

multiElement notation does not work for comments #8768

Closed
caitp opened this issue Aug 26, 2014 · 3 comments
Closed

multiElement notation does not work for comments #8768

caitp opened this issue Aug 26, 2014 · 3 comments

Comments

@caitp
Copy link
Contributor

caitp commented Aug 26, 2014

Based on #8721 (comment) --- there may be use cases for doing something like

<!-- directive: ng-if-start someCondition -->
  <div ng-if="someCondition.someOtherCondition1">
    <img src="fancycontent.jpeg">
  </div>
  <div ng-if="someCondition.someOtherCondition2">
    <img src="otherfancycontent.jpeg">
  </div>
<!-- directive: ng-if-end -->

--- Such that the wrapper directives aren't actually included in the DOM.

It would be a bit of a refactoring of the compiler, and usually you'd be crazy to use comment directives, but it doesn't seem totally unreasonable to me.

Thoughts? Feelings?

@caitp caitp added this to the Backlog milestone Aug 26, 2014
@caitp
Copy link
Contributor Author

caitp commented Aug 26, 2014

Talked about it with Igor, as expected it's not something we're going to fix (although it should be a pretty tiny refactoring)

@caitp caitp closed this as completed Aug 26, 2014
@rodyhaddad
Copy link
Contributor

Related to #3379, my first angular PR :')

@caitp
Copy link
Contributor Author

caitp commented Aug 29, 2014

Yeah I guess so, looks like you got the same answer from Igor back then :p

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants