Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Text input directive applied to inappropriate input elements #6244

Closed
twhitbeck opened this issue Feb 13, 2014 · 2 comments
Closed

Text input directive applied to inappropriate input elements #6244

twhitbeck opened this issue Feb 13, 2014 · 2 comments

Comments

@twhitbeck
Copy link
Contributor

Browser: Chrome
Component: misc core
Regression: no

For example, an gets the textInput directive applied. It's not very useful. Directive stacking means it's not a huge deal, since you can apply your own directive on top. But I like the cleanest possible approach. My change uses the "type" property, which allows the browser to decide what type an input is going to be (defaulting to "text" if need be) and then only applies the directives for matching types.

@caitp
Copy link
Contributor

caitp commented Feb 13, 2014

You've already got a PR open for this, you don't need to open a separate issue :) Closing this and directing people to the PR at #6243

@caitp caitp closed this as completed Feb 13, 2014
@twhitbeck
Copy link
Contributor Author

ty, my first pull request so this was a bit of an experiment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants