Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Broken build: bower install dies prematurely #3648

Closed
benlesh opened this issue Aug 19, 2013 · 8 comments
Closed

Broken build: bower install dies prematurely #3648

benlesh opened this issue Aug 19, 2013 · 8 comments
Milestone

Comments

@benlesh
Copy link
Contributor

benlesh commented Aug 19, 2013

I followed the instructions listed at the guidelines for contributing and for setting up my environment.

I'm unable to build or test angular.

Building issues

This seems to center mostly on the fact I don't have the google closure compiler installed in the proper spot.

when I run:

grunt package

I get the following: (it seems to make the "full" files, but it aborts while creating the minified files)

npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] devDependences should probably be devDependencies.
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] 'repositories' (plural) Not supported.
npm WARN package.json Please pick one as the 'repository' field
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
Running "shell:bower" (shell) task

Running "clean:build" (clean) task
Cleaning "build"...OK

Running "buildall" task

File build/angular-scenario.js created.
File build/angular.js created.
File build/angular-loader.js created.
File build/angular-mobile.js created.
File build/angular-mocks.js created.
File build/angular-sanitize.js created.
File build/angular-resource.js created.
File build/angular-route.js created.
File build/angular-cookies.js created.

Running "minall" task
Error: Unable to access jarfile components/closure-compiler/compiler.jar
Error: Unable to access jarfile components/closure-compiler/compiler.jar
Warning: Error minifying build/angular.js Use --force to continue.

Aborted due to warnings.

Testing issues

If I run:

grunt test:unit

The output is as follows:

[2013-08-18 20:11:08.972] [DEBUG] config - autoWatch set to false, because of > > singleRun
INFO [karma]: Karma server started at http://localhost:9876/
INFO [launcher]: Starting browser Chrome
WARN [watcher]: Pattern "C:/Git/angular.js/components/jquery/jquery.js" does not match any file.
WARN [watcher]: All files matched by "C:/Git/angular.js/test/ngScenario/jstd-scenario-adapter/*.js" were excluded.
INFO [Chrome 28.0 (Windows)]: Connected on socket id 5OrjI9y4oLFkFN6J6TVL
Chrome 28.0 (Windows) ERROR
Uncaught ReferenceError: jQuery is not defined
at C:/Git/angular.js/test/jquery_remove.js:3
Chrome 28.0 (Windows): Executed 0 of 0 ERROR (1.056 secs / 0 secs)
Warning: Test(s) failed Use --force to continue.

Aborted due to warnings.

I'm sure I'm just doing something wrong. I'd just like some guidance. I'd love to contribute.

@benlesh
Copy link
Contributor Author

benlesh commented Aug 19, 2013

Also, I apologize if this is the wrong place for an issue with the build.

@benlesh
Copy link
Contributor Author

benlesh commented Aug 19, 2013

A few things I found:

bower install

runs into an issue where the URL for the bootstrap 2.0.2 .zip file is no longer valid, resulting in a 404. Since this happens before the closure compiler dependency is updated, it never installs the closure compiler. So that's one thing. If you update that URL in bower.json to "bootstrap": "https://github.com/twbs/bootstrap/archive/v2.0.2.zip", it gets past that.

... then when I did a bower install I got further, but I had an issue with "process.nextTick detected" in an infinite loop that originates from a dependency in bower called "tmp".

@IgorMinar
Copy link
Contributor

it sounds like you are working off of an old branch or your master branch is very outdated.

we don't use shell:bower to do bower install any more, but the issue you are describing is something we see on Travis and can't reproduce anywhere else!

Can you please provide information about your environment? Mainly OS + node version.

I'm really intrigued about your "process.nextTick detected" comment, can you please provide more information about this? I suspected that the issue is bower specific (or something coming via bower dependencies) as well as that it has something to do with the event loop, but could never reproduce this on a machine that would allow me to confirm my suspicion.

cc: @btford @vojtajina @chirayuk

@IgorMinar
Copy link
Contributor

We initially field an issue with Travis travis-ci/travis-ci#1293 because that was the only place where we could see the bug manifest but I'm growing more and more convinced that it has nothing to do with Travis but is rather a node/bower/bower-dependency specific issue

@IgorMinar
Copy link
Contributor

this is likely unrelated, but recently I've seen several local build failures due to missing npm dependencies, as if npm install exited prematurely too.. I'm likely wrong, but I'm adding the console output in case it is related:

Running "docs:process" (docs) task
Generating AngularJS Reference Documentation...
DONE. Generated 281 pages in 6316ms.
>> docs created

Running "copy:i18n" (copy) task
Created 1 directories, copied 287 files

Running "write:versionTXT" (write) task
>> wrote to build/version.txt

Running "write:versionJSON" (write) task
>> wrote to build/version.json

Running "compress:build" (compress) task
Warning: Cannot find module './encodings/singlebyte' Use --force to continue.

Aborted due to warnings.
Warning: Process exited before Archiver could finish emitting data Use --force to continue.

Aborted due to warnings.

@benlesh
Copy link
Contributor Author

benlesh commented Aug 23, 2013

@IgorMinar thanks for the input... I'm probably not going to be able to check on this tonight, but I'll get a look at it tomorrow.

My environment is Windows 7 Ultimate and Node version is the latest as of last Sunday. I updated when I had problems.... I think that's 10.16... I think... I'll double check that when I get to my work machine as well.

@IgorMinar
Copy link
Contributor

we used this as a workaround for Travis: 3379eeb

@benlesh
Copy link
Contributor Author

benlesh commented Sep 4, 2013

Thanks. I'll have a look later this evening.

Didn't get a chance last night, I'll try to work in time soon.

@benlesh benlesh closed this as completed Oct 23, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants