Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Remove all items deprecated for 1.7.0 #16423

Closed
petebacondarwin opened this issue Jan 29, 2018 · 4 comments
Closed

Remove all items deprecated for 1.7.0 #16423

petebacondarwin opened this issue Jan 29, 2018 · 4 comments
Milestone

Comments

@petebacondarwin
Copy link
Contributor

No description provided.

@petebacondarwin petebacondarwin added this to the 1.7.0 milestone Jan 29, 2018
@Narretz
Copy link
Contributor

Narretz commented Feb 5, 2018

Since only cookieStore is deprecated and ready for removal (compared to replace: true which won't be removed), I think this can be closed, since there's an extra issue for cookieStore: #16425

@Narretz Narretz closed this as completed Feb 5, 2018
@peterblazejewicz
Copy link

Hi,

Since only cookieStore is deprecated and ready for removal

Can someone review documentation for deprecated items information to be aligned with above for 1.7?

For example the FAQ section states:

When are deprecated features removed from the library?
Most of the time we remove a deprecated feature in a next minor version bump. For example, the preAssignBindingsEnabled $compileProvider method was defined in AngularJS 1.5.10, deprecated in 1.6 and will be removed in 1.7.

https://docs.angularjs.org/misc/faq

We are using docs to make some decisions, should we stick to the 1.7.0 milestone only list as the single source of truth?

Thanks!

@Narretz
Copy link
Contributor

Narretz commented Feb 18, 2018

preAssignBindingsEnabled has already been removed in master branch and will therefore be gone in 1.7. So yeah the milestone should contain every feature removal that goes into 1.7. There's unfortunately no good way to filter only thise issues / PRs though.

@peterblazejewicz
Copy link

Thx. I hope you understand my stance here. Some will have to make decision based on probably release notes/milestone details.
Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants