ng-messages eats all memory and crashes after removeMessageNode call

[olegccc]

Hi,

Please see the attached picture. Immediately after current line is invoked two elements in the message list start to link to each other which results in that the page eats all available memory and crashes in 5 seconds.

Probably the reason is that the node tree is as is:

<ng-messages><ng-transclude><ng-message/><ng-message/></ng-transclude></ng-messages>

Version: 1.4.8

[olegccc]

UPD: not 'propably' but 'definitely'. After removing ng-transclude sublevel, the error is gone. Anyway it is something which should never happen.

[Narretz]

Can you please create a minimal demo that reproduces the problem?

[Narretz]

Closing due to lack of feedback and minimal demo.

[colinfindlay-nz]

I can confirm I'm also seeing something very similar - but I can't pin down why it's happening. I've attempted a minimal demo, but without knowing the specific combination of factors, it's like looking for a needle in a haystack. I do however have a production website exhibiting this behaviour I can point a someone to for easy replication!

[gkalpak]

This sounds pretty much like the bug that was fixed in #14242.
@silver2k or @olegccc, could you confirm that the problem is gone using the latest code from master (e.g. from https://code.angularjs.org/snapshot/angular-messages.js) ?

[Narretz]

The fix is not yet in a 1.4 release, though.

[colinfindlay-nz]

Exactly - upgrading to 1.5 and confirming the bug is gone probably isn't a great test. Is there a chance of backporting the fix to 1.4? Crashing the browser seems pretty significant.

[gkalpak]

@silver2k, it has been backported to the v1.4.x branch, so it will be included in the upcoming 1.4.11 release. Stay tuned 😃

[Narretz]

1.4.11 is available!

[gkalpak]

v1.4.11 is out 😃

[sswayney]

Just in case it helps anyone else. I had some sort of issue with ng-messages and out of memory errors in firefox and chrome. I watched using the firefox profiler and came to the realization it had something to do with ng-messages. I was using angular and angular-messages 1.4.9 and moved to 1.4.11 and the issue was gone.

[gkalpak]

Thx for confirming, @sswayney.