Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

There is a small problem in AngularJS Git Commit Message Conventions on google docs #12339

Closed
stevemao opened this issue Jul 14, 2015 · 4 comments
Milestone

Comments

@stevemao
Copy link
Contributor

Related PR: #12032

The type is mandatory and the scope is optional

is wrong. It should say The header is mandatory and the scope of the header is optional.
You could also say "The type and subject is mandatory and the scope is optional in the header, and other parts are optional".

I also think a git repo would be easier for us to contribute than google docs...
@petebacondarwin

@Narretz
Copy link
Contributor

Narretz commented Jul 14, 2015

This has been changed in our contributing.md yesterday. I am not sure we can edit this google doc, or if this change should be tracked here. Wdyt @petebacondarwin ?

@Narretz Narretz added this to the Purgatory milestone Jul 14, 2015
@petebacondarwin
Copy link
Contributor

I have tweaked the Google doc further. I have changed the doc to allow public comments to make it easier to collaborate on that document. @stevemao please close this issue if that is acceptable.

@stevemao
Copy link
Contributor Author

Thanks @petebacondarwin , Looks good for now. Just a few things:

  1. I updated table of contents (as there is some mismatch with the new titles). Not sure if you see my suggestion.
  2. When I open the doc, I'm in "Suggesting mode". I think it would be better to be in "Viewing mode" by default. Not sure if you can change this though. Or is it just my machine.

@petebacondarwin
Copy link
Contributor

Thanks @stevemao. I don't think we can control what the default view you get is...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants