Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

orderBy reverses order of array of objects when no predicate is given, 1.2.x #10488

Closed
lazychino opened this issue Dec 16, 2014 · 5 comments
Closed

Comments

@lazychino
Copy link

Today I found that the change in commit 45b896a, changes the order of an array containing objects when no predicate is given

example

this affect a table directive on my app that have optional sorting

I'll try to fix this and add testing for this case

@lazychino lazychino changed the title orderBy reverses order of array of abject when no predicate is given orderBy reverses order of array of objects when no predicate is given Dec 16, 2014
@Narretz
Copy link
Contributor

Narretz commented Dec 16, 2014

Have you tried with the latest snapshot / >= 1.3.6? This should have been fixed a few days ago: 8bfeddb

@lazychino
Copy link
Author

@Narretz hehe let me see, I only tried with 1.2.x

@lazychino
Copy link
Author

that fix it, thanks!

@lazychino
Copy link
Author

@Narretz does this fix will be added to 1.2.x??? ui-bootstrap breaks with 1.3 and my app depends on it

@lazychino lazychino reopened this Dec 29, 2014
@lazychino lazychino changed the title orderBy reverses order of array of objects when no predicate is given orderBy reverses order of array of objects when no predicate is given, 1.2.x Dec 29, 2014
@pkozlowski-opensource
Copy link
Member

@lazychino no, I'm afraid that 1.2.x is going to get only to get only critical security and perf fixes.
Closing as this is sorted out in 1.3.x.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants