Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

$minErr module loading error can cause truncated URLs #10285

Closed
jeffbcross opened this issue Dec 1, 2014 · 3 comments
Closed

$minErr module loading error can cause truncated URLs #10285

jeffbcross opened this issue Dec 1, 2014 · 3 comments

Comments

@jeffbcross
Copy link
Contributor

Since the 2nd minErr argument is often the error's stack trace when trying to load modules, the url can often be cut off by the browser.

throw $injectorMinErr('modulerr', "Failed to instantiate module {0} due to:\n{1}",

This message should be replaced with something more intelligent, ideally showing which dependent module was missing or broken.

@chirayuk
Copy link
Contributor

chirayuk commented Dec 1, 2014

Under what circumstances is the URL cut off by the browser?

@petebacondarwin
Copy link
Contributor

If the call stack is very long then the URL can also be very long. This is common when there are error messages in loading modules and in infinite digests. Also I think there is often some kind of recursion in the messages where you have to click through a number of times to get to the actual error message.

TLDR; improve the error messages from the core.

@petebacondarwin petebacondarwin modified the milestones: 1.5.x - migration-facilitation, 1.3.x - superluminal-nudge Sep 14, 2015
@Narretz
Copy link
Contributor

Narretz commented Mar 16, 2018

Depending on what causes it, the error will already show context. Otherwise this is just a special case of #14744

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants