Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngDisabled reference highlights incorrect usage #10100

Closed
LegalizeAdulthood opened this issue Nov 17, 2014 · 3 comments
Closed

ngDisabled reference highlights incorrect usage #10100

LegalizeAdulthood opened this issue Nov 17, 2014 · 3 comments
Labels
component: misc core severity: confusing type: docs
Milestone
1.3.x - superlumi...

Comments

@LegalizeAdulthood
Copy link
Contributor

ngDisabled starts out by showing a big code block of what not to do. IMO, this is bad form, as folks tend to copy/paste the first thing that they see and the code block has no comments indicating that this is poor form.

I suggest the page be reworked to more closely resemble the documentation for ngChecked, which handles the same problem but for the checked attribute instead of the disabled attribute.
@caitp
Copy link
Contributor

caitp commented Nov 17, 2014

you're right, this sucks --- however we do want to provide an explanation as to why it sucks.

Care to submit a patch?

@caitp caitp added this to the 1.3.x milestone Nov 17, 2014
@LegalizeAdulthood
Copy link
Contributor Author

Sorry, but the whole CLA nag process demanding lots of personal information from me puts me off from submitting patches to angular.

@pkozlowski-opensource
Copy link
Member

This is duplicate of #11032 for which I've just sent a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: misc core severity: confusing type: docs
Projects
None yet
Milestone
1.3.x - superluminal-nudge
Development

No branches or pull requests
3 participants
@pkozlowski-opensource @caitp @LegalizeAdulthood