Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit fbe84f9

Browse files
committed
chore(browserstack): Update browserstacktunnel-wrapper, fix options
Only the latest version of the package works correctly (the backend for it at BrowserStack is not versioned) and the options have changed in the new version of the package. Also, iOS 8.0 is no longer available on BrowserStack, only 8.3 is. Instead, this commit changes it to 9.3 as we shouldn't be testing on 8 anymore anyway. (a late cherry-pick of ad0bb83) Closes #15892
1 parent 3671a43 commit fbe84f9

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

karma-shared.conf.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,9 @@ module.exports = function(config, specificOptions) {
122122
},
123123
'BS_iOS': {
124124
base: 'BrowserStack',
125-
device: 'iPhone 6',
125+
device: 'iPhone 6S',
126126
os: 'ios',
127-
os_version: '8.0'
127+
os_version: '9.3'
128128
}
129129
}
130130
});

lib/browserstack/start_tunnel.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ PORTS.forEach(function(port) {
2525

2626
var tunnel = new BrowserStackTunnel({
2727
key: ACCESS_KEY,
28-
tunnelIdentifier: TUNNEL_IDENTIFIER,
28+
localIdentifier: TUNNEL_IDENTIFIER,
2929
hosts: hosts
3030
});
3131

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"benchmark": "1.x.x",
2525
"bootstrap": "3.1.1",
2626
"bower": "~1.3.9",
27-
"browserstacktunnel-wrapper": "^1.4.2",
27+
"browserstacktunnel-wrapper": "2.0.0",
2828
"canonical-path": "0.0.2",
2929
"changez": "^2.1.1",
3030
"changez-angular": "^2.1.3",

yarn.lock

+7-1
Original file line numberDiff line numberDiff line change
@@ -770,7 +770,13 @@ [email protected]:
770770
dependencies:
771771
https-proxy-agent "1.0.0"
772772

773-
browserstacktunnel-wrapper@^1.4.2, browserstacktunnel-wrapper@~1.4.2:
773+
774+
version "2.0.0"
775+
resolved "https://registry.yarnpkg.com/browserstacktunnel-wrapper/-/browserstacktunnel-wrapper-2.0.0.tgz#4d6ebf6a667451ad4ee9325fddcf3546607b4d92"
776+
dependencies:
777+
unzip "~0.1.9"
778+
779+
browserstacktunnel-wrapper@~1.4.2:
774780
version "1.4.2"
775781
resolved "https://registry.yarnpkg.com/browserstacktunnel-wrapper/-/browserstacktunnel-wrapper-1.4.2.tgz#6598fb7d784b6ff348e3df7c104b0d9c27ea5275"
776782
dependencies:

0 commit comments

Comments
 (0)