refactor($parse): rename simpleEquals to expressionInputDirtyCheck

Author: IgorMinar

src/ng/parse.js

@@ -1083,28 +1083,28 @@ function $ParseProvider() {
       return list;
     }
 
-    function simpleEquals(o1, o2) {
-      if (o1 == null || o2 == null) return o1 === o2; // null/undefined
+    function expressionInputDirtyCheck(newValue, oldValue) {
+      if (newValue == null || oldValue == null) return newValue === oldValue; // null/undefined
 
-      if (typeof o1 === "object") {
+      if (typeof newValue === 'object') {
 
         // attempt to convert the value to a primitive type
         // TODO(docs): add a note to docs that by implementing valueOf even objects and arrays can
         //             be cheaply dirty-checked
-        o1 = o1.valueOf();
+        newValue = newValue.valueOf();
 
-        if (typeof o1 === "object") {
+        if (typeof newValue === 'object') {
           // objects/arrays are not supported - deep-watching them would be too expensive
           return false;
         }
 
-        o2 = o2.valueOf();
+        oldValue = oldValue.valueOf();
 
         // fall-through to the primitive equality check
       }
 
       //Primitive or NaN
-      return o1 === o2 || (o1 !== o1 && o2 !== o2);
+      return newValue === oldValue || (newValue !== newValue && oldValue !== oldValue);
     }
 
     function inputsWatchDelegate(scope, listener, objectEquality, parsedExpression) {
@@ -1114,11 +1114,11 @@ function $ParseProvider() {
       var lastResult;
 
       if (inputExpressions.length === 1) {
-        var oldInputValue = simpleEquals; // init to something unique so that equals check fails
+        var oldInputValue = expressionInputDirtyCheck; // init to something unique so that equals check fails
         inputExpressions = inputExpressions[0];
         return scope.$watch(function expressionInputWatch(scope) {
           var newInputValue = inputExpressions(scope);
-          if (!simpleEquals(newInputValue, oldInputValue)) {
+          if (!expressionInputDirtyCheck(newInputValue, oldInputValue)) {
             lastResult = parsedExpression(scope);
             oldInputValue = newInputValue;
           }
@@ -1128,15 +1128,15 @@ function $ParseProvider() {
 
       var oldInputValues = [];
       for (var i = 0, ii = inputExpressions.length; i < ii; i++) {
-        oldInputValues[i] = simpleEquals; // init to something unique so that equals check fails
+        oldInputValues[i] = expressionInputDirtyCheck; // init to something unique so that equals check fails
       }
 
       return scope.$watch(function expressionInputsWatch(scope) {
         var changed = false;
 
         for (var i = 0, ii = inputExpressions.length; i < ii; i++) {
           var newInputValue = inputExpressions[i](scope);
-          if (changed || (changed = !simpleEquals(newInputValue, oldInputValues[i]))) {
+          if (changed || (changed = !expressionInputDirtyCheck(newInputValue, oldInputValues[i]))) {
             oldInputValues[i] = newInputValue;
           }
         }