test(*): fix tests involving submit on Chrome 60

On Chrome 60 (at least on Windows) the `submit` event when clicking on a submit
button is not fired on the form element, unless it is already part of the DOM.

Author: gkalpak

test/ng/directive/formSpec.js

@@ -386,6 +386,9 @@ describe('form', function() {
       doc = jqLite('<form ng-submit="submitMe()">' +
                      '<input type="submit" value="submit">' +
                    '</form>');
+      // Support: Chrome 60+ (on Windows)
+      // We need to add the form to the DOM in order for `submit` events to be properly fired.
+      window.document.body.appendChild(doc[0]);
 
       var assertPreventDefaultListener = function(e) {
         reloadPrevented = e.defaultPrevented || (e.returnValue === false);
@@ -420,15 +423,18 @@ describe('form', function() {
       inject(function($timeout) {
         doc = jqLite('<div>' +
                         '<form ng-submit="submitMe()">' +
-                          '<button ng-click="destroy()"></button>' +
+                          '<button type="submit" ng-click="destroy()"></button>' +
                         '</form>' +
                       '</div>');
+        // Support: Chrome 60+ (on Windows)
+        // We need to add the form to the DOM in order for `submit` events to be properly fired.
+        window.document.body.appendChild(doc[0]);
 
         var form = doc.find('form'),
             destroyed = false,
             nextTurn = false,
             submitted = false,
-            reloadPrevented;
+            reloadPrevented = 'never called';
 
         scope.destroy = function() {
           // yes, I know, scope methods should not do direct DOM manipulation, but I wanted to keep
@@ -460,6 +466,7 @@ describe('form', function() {
         .runs(function() {
           expect(doc.html()).toBe('');
           expect(destroyed).toBe(true);
+          expect(reloadPrevented).toBe('never called');
           expect(submitted).toBe(false); // this is known corner-case that is not currently handled
                                          // the issue is that the submit listener is destroyed before
                                          // the event propagates there. we can fix this if we see

test/ng/directive/ngEventDirsSpec.js

@@ -12,15 +12,20 @@ describe('event directives', function() {
   describe('ngSubmit', function() {
 
     it('should get called on form submit', inject(function($rootScope, $compile) {
-      element = $compile('<form action="/foo" ng-submit="submitted = true">' +
-        '<input type="submit"/>' +
+      element = $compile(
+        '<form action="/foo" ng-submit="submitted = true">' +
+          '<input type="submit" />' +
         '</form>')($rootScope);
       $rootScope.$digest();
 
+      // Support: Chrome 60+
+      // We need to add the form to the DOM in order for `submit` events to be properly fired.
+      window.document.body.appendChild(element[0]);
+
       // prevent submit within the test harness
       element.on('submit', function(e) { e.preventDefault(); });
 
-      expect($rootScope.submitted).not.toBeDefined();
+      expect($rootScope.submitted).toBeUndefined();
 
       browserTrigger(element.children()[0]);
       expect($rootScope.submitted).toEqual(true);
@@ -33,15 +38,20 @@ describe('event directives', function() {
         }
       };
 
-      element = $compile('<form action="/foo" ng-submit="formSubmission($event)">' +
-        '<input type="submit"/>' +
+      element = $compile(
+        '<form action="/foo" ng-submit="formSubmission($event)">' +
+          '<input type="submit" />' +
         '</form>')($rootScope);
       $rootScope.$digest();
 
+      // Support: Chrome 60+ (on Windows)
+      // We need to add the form to the DOM in order for `submit` events to be properly fired.
+      window.document.body.appendChild(element[0]);
+
       // prevent submit within the test harness
       element.on('submit', function(e) { e.preventDefault(); });
 
-      expect($rootScope.formSubmitted).not.toBeDefined();
+      expect($rootScope.formSubmitted).toBeUndefined();
 
       browserTrigger(element.children()[0]);
       expect($rootScope.formSubmitted).toEqual('foo');