refactor($q): replace occurrences of .when() with .resolve()

Related to #13709.

Closes #15442

Author: wesleycho

docs/app/src/examples.js

@@ -114,7 +114,7 @@ angular.module('examples', [])
 
       ctrl.prepareExampleData = function() {
         if (ctrl.example.manifest) {
-          return $q.when(ctrl.example);
+          return $q.resolve(ctrl.example);
         }
 
         return getExampleData(ctrl.examplePath).then(function(data) {

docs/content/guide/component-router.ngdoc

@@ -215,7 +215,7 @@ You can see the complete application running below.
 
 
     function HeroService($q) {
-      var heroesPromise = $q.when([
+      var heroesPromise = $q.resolve([
         { id: 11, name: 'Mr. Nice' },
         { id: 12, name: 'Narco' },
         { id: 13, name: 'Bombasto' },
@@ -308,7 +308,7 @@ You can see the complete application running below.
 
 
     function CrisisService($q) {
-      var crisesPromise = $q.when([
+      var crisesPromise = $q.resolve([
         {id: 1, name: 'Princess Held Captive'},
         {id: 2, name: 'Dragon Burning Cities'},
         {id: 3, name: 'Giant Asteroid Heading For Earth'},
@@ -415,7 +415,7 @@ You can see the complete application running below.
 
     function DialogService($q) {
       this.confirm = function(message) {
-        return $q.when(window.confirm(message || 'Is it OK?'));
+        return $q.resolve(window.confirm(message || 'Is it OK?'));
       };
     }
   </file>
@@ -714,7 +714,7 @@ making an actual server request, perhaps over HTTP.
 
 ```js
 function HeroService($q) {
-  var heroesPromise = $q.when([
+  var heroesPromise = $q.resolve([
     { id: 11, name: 'Mr. Nice' },
     ...
   ]);
@@ -991,7 +991,7 @@ have made. The result of the prompt is a promise that can be used in a `$routerC
 
 function DialogService($q) {
   this.confirm = function(message) {
-    return $q.when(window.confirm(message || 'Is it OK?'));
+    return $q.resolve(window.confirm(message || 'Is it OK?'));
   };
 }
 ```

docs/content/guide/forms.ngdoc

@@ -396,7 +396,7 @@ In the following example we create two directives:
 
             if (ctrl.$isEmpty(modelValue)) {
               // consider empty model valid
-              return $q.when();
+              return $q.resolve();
             }
 
             var def = $q.defer();

src/ng/http.js

@@ -972,7 +972,7 @@ function $HttpProvider() {
 
       var requestInterceptors = [];
       var responseInterceptors = [];
-      var promise = $q.when(config);
+      var promise = $q.resolve(config);
 
       // apply interceptors
       forEach(reversedInterceptors, function(interceptor) {

test/ng/httpSpec.js

@@ -58,7 +58,7 @@ describe('$http', function() {
             return {
               requestError: function(error) {
                 savedConfig.url += error;
-                return $q.when(savedConfig);
+                return $q.resolve(savedConfig);
               }
             };
           });
@@ -269,7 +269,7 @@ describe('$http', function() {
           $provide.factory('myInterceptor', function($q, $rootScope) {
             return {
               request: function(config) {
-                return $q.when('/intercepted').then(function(intercepted) {
+                return $q.resolve('/intercepted').then(function(intercepted) {
                   config.url = intercepted;
                   return config;
                 });

test/ngAnimate/animationSpec.js

@@ -976,7 +976,7 @@ describe('$$animation', function() {
         $$animationProvider.drivers[0] = 'dumbDriver';
         $provide.factory('dumbDriver', function($q) {
           return function stepFn() {
-            return $q.when(true);
+            return $q.resolve(true);
           };
         });
       });