[WIP] code review

Author: mgol

Gruntfile.js

@@ -126,7 +126,7 @@ module.exports = function(grunt) {
           'src/**/*.js',
           'test/**/*.js',
           'i18n/**/*.js',
-          '!docs/app/assets/**',
+          '!docs/app/assets/js/angular-bootstrap/**',
           '!docs/bower_components/**',
           '!docs/config/templates/**',
           '!src/angular.bind.js',

benchmarks/largetable-bp/app.js

@@ -23,9 +23,9 @@ app.controller('DataController', function DataController($scope, $rootScope) {
   $scope.numberOfBindings = totalRows * totalColumns * 2 + totalRows + 1;
   $scope.numberOfWatches = '?';
 
-  /* @this DataController */
+  /* @this */
   function iGetter() { return this.i; }
-  /* @this DataController */
+  /* @this */
   function jGetter() { return this.j; }
 
   for (var i = 0; i < totalRows; i++) {

src/ngResource/resource.js

@@ -425,7 +425,7 @@ function shallowClearAndCopy(src, dst) {
  *
  */
 angular.module('ngResource', ['ng']).
-  provider('$resource', function Resource() {
+  provider('$resource', function ResourceProvider() {
     var PROTOCOL_AND_DOMAIN_REGEX = /^https?:\/\/[^\/]*/;
 
     var provider = this;

test/AngularSpec.js

@@ -2,8 +2,8 @@
 
 // Lots of typed array globals are used in this file and ESLint is
 // not smart enough to understand the `typeof !== 'undefined'` guards.
-/* eslint-env es6 */
-/* globals Blob */
+/* globals Blob, Uint8ClampedArray, Uint16Array, Uint32Array, Int8Array, Int16Array, Int32Array,
+Float32Array, Float64Array,  */
 
 describe('angular', function() {
   var element, document;
@@ -568,29 +568,26 @@ describe('angular', function() {
     });
 
     it('should copy String() objects', function() {
-      /* eslint-disable no-new-wrappers */
+      // eslint-disable-next-line no-new-wrappers
       var obj = new String('foo');
-      /* eslint-enable */
       var dest = copy(obj);
       expect(dest).not.toBe(obj);
       expect(isObject(dest)).toBe(true);
       expect(dest.valueOf()).toBe(obj.valueOf());
     });
 
     it('should copy Boolean() objects', function() {
-      /* eslint-disable no-new-wrappers */
+      // eslint-disable-next-line no-new-wrappers
       var obj = new Boolean(true);
-      /* eslint-enable */
       var dest = copy(obj);
       expect(dest).not.toBe(obj);
       expect(isObject(dest)).toBe(true);
       expect(dest.valueOf()).toBe(obj.valueOf());
     });
 
     it('should copy Number() objects', function() {
-      /* eslint-disable no-new-wrappers */
+      // eslint-disable-next-line no-new-wrappers
       var obj = new Number(42);
-      /* eslint-enable */
       var dest = copy(obj);
       expect(dest).not.toBe(obj);
       expect(isObject(dest)).toBe(true);

test/e2e/tools/.eslintrc.json

@@ -1,8 +1,4 @@
 {
   "root": true,
-  "extends": "../../../.eslintrc-node.json",
-
-  "env": {
-    "jasmine": false
-  }
+  "extends": "../../../.eslintrc-node.json"
 }

test/helpers/privateMocks.js

@@ -31,7 +31,7 @@ function xthey(msg, vals, spec) {
 }
 
 function browserSupportsCssAnimations() {
-  // Support: IE < 11
+  // Support: IE < 10
   // Only IE10+ support keyframes / transitions
   return !(window.document.documentMode < 10);
 }

test/helpers/testabilityPatch.js

@@ -230,7 +230,7 @@ function sortedHtml(element, showNgClass) {
         }
         for (var css in node.style) {
           var value = node.style[css];
-          if (isString(value) && isString(css) && css !== 'cssText' && value && (1 * css !== css)) {
+          if (isString(value) && isString(css) && css !== 'cssText' && value && isNaN(Number(css))) {
             var text = lowercase(css + ': ' + value);
             if (value !== 'false' && style.indexOf(text) === -1) {
               style.push(text);

test/ng/directive/ngRepeatSpec.js

@@ -1143,7 +1143,7 @@ describe('ngRepeat', function() {
       scope.$digest();
       expect($exceptionHandler.errors.shift().message).
           toMatch(
-            /^\[ngRepeat:dupes] Duplicates in a repeater are not allowed\. Use 'track by' expression to specify unique keys\. Repeater: item in items, Duplicate key: object:3, Duplicate value: /);
+            /^\[ngRepeat:dupes] Duplicates in a repeater are not allowed\. Use 'track by' expression to specify unique keys\. Repeater: item in items, Duplicate key: object:3, Duplicate value: {}/);
 
       // recover
       scope.items = [a];
@@ -1164,7 +1164,7 @@ describe('ngRepeat', function() {
       scope.$digest();
       expect($exceptionHandler.errors.shift().message).
           toMatch(
-            /^\[ngRepeat:dupes] Duplicates in a repeater are not allowed\. Use 'track by' expression to specify unique keys\. Repeater: item in items, Duplicate key: object:9, Duplicate value: /);
+            /^\[ngRepeat:dupes] Duplicates in a repeater are not allowed\. Use 'track by' expression to specify unique keys\. Repeater: item in items, Duplicate key: object:9, Duplicate value: {}/);
 
       // recover
       scope.items = [a];

test/ng/parseSpec.js

@@ -2946,15 +2946,15 @@ describe('parser', function() {
           });
         });
 
-       it('should prevent the exploit', function() {
+        it('should prevent the exploit', function() {
           expect(function() {
             scope.$eval('(1)[{0: "__proto__", 1: "__proto__", 2: "__proto__", 3: "safe", length: 4, toString: [].pop}].foo = 1');
           }).toThrow();
           if (!msie || msie > 10) {
             // eslint-disable-next-line no-proto
             expect((1)['__proto__'].foo).toBeUndefined();
           }
-       });
+        });
 
         it('should prevent the exploit', function() {
           expect(function() {

test/ngMock/angular-mocksSpec.js

@@ -948,7 +948,7 @@ describe('ngMock', function() {
           if (!error.stack) {
             try {
               throw error;
-            } catch (e) { /** do nothing **/}
+            } catch (e) { /* empty */}
           }
 
           return !!error.stack;