[WIP] More changes

Author: mgol

.eslintignore

@@ -2,8 +2,10 @@ bower_components/**
 build/**
 docs/bower_components/**
 docs/app/assets/**
+docs/config/templates/**
 node_modules/**
 lib/htmlparser/**
+src/angular.bind.js
 src/ngParseExt/ucd.js
 i18n/closure/**
 tmp/**

.eslintrc.json

@@ -41,7 +41,7 @@
     // Best practices
     "accessor-pairs": "error",
     "array-callback-return": "error",
-    "complexity": ["warn", 10],
+//    "complexity": ["error", 10], // TODO enable?
 //    "dot-notation": "error", // TODO enable?
 //    "dot-location": ["error", "property"], // TODO enable?
     "eqeqeq": ["error", "allow-null"],

Gruntfile.js

@@ -119,9 +119,18 @@ module.exports = function(grunt) {
       all: {
         src: [
           '*.js',
+          'docs/**/*.js',
+          'lib/**/*.js',
+          'scripts/**/*.js',
           'src/**/*.js',
           'test/**/*.js',
-          'i18n/**/*.js'
+          'i18n/**/*.js',
+          '!docs/app/assets/**',
+          '!docs/bower_components/**',
+          '!docs/config/templates/**',
+          '!src/angular.bind.js',
+          '!i18n/closure/**',
+          '!src/ngParseExt/ucd.js'
         ]
       }
     },

docs/app/src/.eslintrc.json

@@ -10,6 +10,8 @@
 
     // ngMocks
     "module": false,
-    "inject": true
+    "inject": true,
+
+    "lunr": false
   }
 }

docs/app/src/docs.js

@@ -29,7 +29,7 @@ angular.module('DocsController', [])
 
     path = path.replace(/^\/?(.+?)(\/index)?\/?$/, '$1');
 
-    currentPage = $scope.currentPage = NG_PAGES[path];
+    var currentPage = $scope.currentPage = NG_PAGES[path];
 
     if (currentPage) {
       $scope.partialPath = 'partials/' + path + '.html';

docs/app/src/errors.js

@@ -3,7 +3,7 @@
 angular.module('errors', ['ngSanitize'])
 
 .filter('errorLink', ['$sanitize', function($sanitize) {
-  var LINKY_URL_REGEXP = /((ftp|https?):\/\/|(mailto:)?[A-Za-z0-9._%+-]+@)\S*[^\s\.\;\,\(\)\{\}<>]/g,
+  var LINKY_URL_REGEXP = /((ftp|https?):\/\/|(mailto:)?[A-Za-z0-9._%+-]+@)\S*[^\s\.;,\(\)\{\}<>]/g,
       MAILTO_REGEXP = /^mailto:/,
       STACK_TRACE_REGEXP = /:\d+:\d+$/;
 

docs/app/src/examples.js

@@ -4,7 +4,6 @@ angular.module('examples', [])
 
 .directive('runnableExample', ['$templateCache', '$document', function($templateCache, $document) {
   var exampleClassNameSelector = '.runnable-example-file';
-  var doc = $document[0];
   var tpl =
     '<nav class="runnable-example-tabs" ng-if="tabs">' +
     '  <a ng-class="{active:$index==activeTabIndex}"' +
@@ -31,7 +30,7 @@ angular.module('examples', [])
       return function(scope, element) {
         var node = element[0];
         var examples = node.querySelectorAll(exampleClassNameSelector);
-        var tabs = [], now = Date.now();
+        var tabs = [];
         angular.forEach(examples, function(child, index) {
           tabs.push(child.getAttribute('name'));
         });
@@ -103,7 +102,7 @@ angular.module('examples', [])
     },
     controllerAs: 'plnkr',
     template: '<button ng-click="plnkr.open($event)" class="btn pull-right"> <i class="glyphicon glyphicon-edit">&nbsp;</i> Edit in Plunker</button> ',
-    controller: [function() {
+    controller: [function Ctrl() {
       var ctrl = this;
 
       ctrl.example = {

docs/app/src/search.js

@@ -43,8 +43,7 @@ angular.module('search', [])
         $scope.hasResults = totalAreas > 0;
         $scope.results = results;
       });
-    }
-    else {
+    } else {
       clearResults();
     }
     if (!$scope.$$phase) $scope.$apply();
@@ -98,7 +97,7 @@ angular.module('search', [])
     console.log('Using Local Search Index');
 
     // Create the lunr index
-    var index = lunr(function() {
+    var index = lunr(/* @this */ function() {
       this.ref('path');
       this.field('titleWords', {boost: 50});
       this.field('members', { boost: 40});

docs/app/test/.eslintrc.json

@@ -5,6 +5,15 @@
     "jasmine": true
   },
 
+  "rules": {
+    // Some rules are not that important in tests and conflict with
+    // Jasmine or would make it easier to write some tests; we disable
+    // those ones here.
+    "no-invalid-this": "off",
+    "no-throw-literal": "off",
+    "no-unused-vars": "off"
+  },
+
   "globals": {
     // AngularJS
     "angular": false,

docs/app/test/directivesSpec.js

@@ -1,3 +1,5 @@
+'use strict';
+
 describe("code", function() {
   var prettyPrintOne, oldPP;
   var compile, scope;

docs/app/test/docsSpec.js

@@ -1,3 +1,5 @@
+'use strict';
+
 describe("DocsController", function() {
   var $scope;
 

docs/config/inline-tag-defs/type.js

@@ -1,5 +1,6 @@
-"use strict";
+'use strict';
 
+// eslint-disable-next-line new-cap
 var encoder = new require('node-html-encoder').Encoder();
 
 /**

docs/config/processors/error-docs.js

@@ -1,7 +1,4 @@
-"use strict";
-
-var _ = require('lodash');
-var path = require('canonical-path');
+'use strict';
 
 /**
  * @dgProcessor errorDocsProcessor

docs/config/processors/index-page.js

@@ -1,7 +1,6 @@
 "use strict";
 
 var _ = require('lodash');
-var path = require('canonical-path');
 
 /**
  * @dgProcessor generateIndexPagesProcessor

docs/config/processors/pages-data.js

@@ -1,4 +1,4 @@
-"use strict";
+'use strict';
 
 var _ = require('lodash');
 var path = require('canonical-path');
@@ -158,7 +158,7 @@ module.exports = function generatePagesDataProcessor(log) {
 
       // We are only interested in pages that are not landing pages
       var navPages = _.filter(pages, function(page) {
-        return page.docType != 'componentGroup';
+        return page.docType !== 'componentGroup';
       });
 
       // Generate an object collection of pages that is grouped by area e.g.

docs/config/tag-defs/installation.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
   name: 'installation'
 };

docs/config/tag-defs/sortOrder.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
   name: 'sortOrder',
   transforms: function(doc, tag, value) {

docs/config/tag-defs/tutorial-step.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
   name: 'step',
   transforms: function(doc, tag, value) {

lib/grunt/plugins.js

@@ -1,13 +1,15 @@
 'use strict';
 
+/* eslint-disable no-invalid-this */
+
 var bower = require('bower');
 var util = require('./utils.js');
 var shelljs = require('shelljs');
 
 module.exports = function(grunt) {
 
   grunt.registerMultiTask('min', 'minify JS files', function() {
-    util.min.call(util, this.data, this.async());
+    util.min(this.data, this.async());
   });
 
 
@@ -19,7 +21,7 @@ module.exports = function(grunt) {
 
 
   grunt.registerMultiTask('build', 'build JS files', function() {
-    util.build.call(util, this.data, this.async());
+    util.build(this.data, this.async());
   });
 
 
@@ -45,20 +47,20 @@ module.exports = function(grunt) {
 
 
   grunt.registerMultiTask('tests', '**Use `grunt test` instead**', function() {
-    util.startKarma.call(util, this.data, true, this.async());
+    util.startKarma(this.data, true, this.async());
   });
 
 
   grunt.registerMultiTask('autotest', 'Run and watch the unit tests with Karma', function() {
-    util.startKarma.call(util, this.data, false, this.async());
+    util.startKarma(this.data, false, this.async());
   });
 
   grunt.registerTask('webdriver', 'Update webdriver', function() {
-    util.updateWebdriver.call(util, this.async());
+    util.updateWebdriver(this.async());
   });
 
   grunt.registerMultiTask('protractor', 'Run Protractor integration tests', function() {
-    util.startProtractor.call(util, this.data, this.async());
+    util.startProtractor(this.data, this.async());
   });
 
   grunt.registerTask('collect-errors', 'Combine stripped error files', function() {

lib/grunt/utils.js

@@ -1,13 +1,9 @@
 'use strict';
 
 var fs = require('fs');
-var path = require('path');
 var shell = require('shelljs');
 var grunt = require('grunt');
 var spawn = require('child_process').spawn;
-var semver = require('semver');
-
-var _ = require('lodash');
 
 var CSP_CSS_HEADER = '/* Include this file in your html if you are using the CSP mode. */\n\n';
 
@@ -108,8 +104,8 @@ module.exports = {
           .replace(/:\s+/g, ':')
           .replace(/\s*\{\s*/g, '{')
           .replace(/\s*\}\s*/g, '}')
-          .replace(/\s*\,\s*/g, ',')
-          .replace(/\s*\;\s*/g, ';');
+          .replace(/\s*,\s*/g, ',')
+          .replace(/\s*;\s*/g, ';');
       }
       //escape for js
       css = css

lib/grunt/validate-angular-files.js

@@ -20,7 +20,7 @@ module.exports = function(grunt) {
     for (var section in combinedFiles) {
       var sectionFiles = combinedFiles[section];
 
-      if (section != 'angularLoader') {
+      if (section !== 'angularLoader') {
         directories.push('src/' + section);
       }
 
@@ -40,7 +40,7 @@ module.exports = function(grunt) {
       glob.sync(directory + '/**/*').forEach(function(filePath) {
         if (!fs.lstatSync(filePath).isDirectory()) {
           var fileName = path.basename(filePath);
-          var isHiddenFile = fileName[0] == '.';
+          var isHiddenFile = fileName[0] === '.';
           if (!isHiddenFile && !detectedFiles[filePath]) {
             grunt.log.error(filePath + ' exists in the local file structure but isn\'t used by any module.');
             errorsDetected = true;

lib/promises-aplus/promises-aplus-test-adapter.js

@@ -9,6 +9,7 @@
  minErr,
  extend
 */
+/* eslint-disable no-unused-vars */
 
 var isFunction = function isFunction(value) {return typeof value === 'function';};
 var isPromiseLike = function isPromiseLike(obj) {return obj && isFunction(obj.then);};

lib/versions/version-info.js

@@ -11,7 +11,7 @@ var process = require('process');
 var NO_REMOTE_REQUESTS = !!process.env['NG1_BUILD_NO_REMOTE_VERSION_REQUESTS'];
 var versionSource = NO_REMOTE_REQUESTS ? 'local' : 'remote';
 
-var currentPackage, previousVersions, cdnVersion, gitRepoInfo;
+var currentPackage, previousVersions, cdnVersion;
 
 
 /**
@@ -211,7 +211,7 @@ var getSnapshotVersion = function() {
 
 
 exports.currentPackage = currentPackage = getPackage();
-exports.gitRepoInfo = gitRepoInfo = getGitRepoInfo();
+exports.gitRepoInfo = getGitRepoInfo();
 exports.previousVersions = previousVersions = getPreviousVersions();
 exports.cdnVersion = cdnVersion = getCdnVersion();
 exports.currentVersion = getTaggedVersion() || getSnapshotVersion();

scripts/npm/clean-shrinkwrap.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict';
+
 /**
  * this script is just a temporary solution to deal with the issue of npm outputting the npm
  * shrinkwrap file in an unstable manner.

src/.eslintrc.json

@@ -5,6 +5,8 @@
 
   "globals": {
     "window": false,
+    "ArrayBuffer": false,
+    "Uint8Array": false,
 
     /* auto/injector.js */
     "createInjector": false,

src/Angular.js

@@ -689,8 +689,10 @@ var trim = function(value) {
 // http://docs.closure-library.googlecode.com/git/local_closure_goog_string_string.js.source.html#line1021
 // Prereq: s is a string.
 var escapeForRegexp = function(s) {
-  return s.replace(/([-()\[\]{}+?*.$\^|,:#<!\\])/g, '\\$1').
-           replace(/\x08/g, '\\x08');
+  return s
+    .replace(/([-()\[\]{}+?*.$\^|,:#<!\\])/g, '\\$1')
+    // eslint-disable-next-line no-control-regex
+    .replace(/\x08/g, '\\x08');
 };
 
 
@@ -1128,7 +1130,8 @@ var jq = function() {
   var i, ii = ngAttrPrefixes.length, prefix, name;
   for (i = 0; i < ii; ++i) {
     prefix = ngAttrPrefixes[i];
-    if (el = window.document.querySelector('[' + prefix.replace(':', '\\:') + 'jq]')) {
+    el = window.document.querySelector('[' + prefix.replace(':', '\\:') + 'jq]');
+    if (el) {
       name = el.getAttribute(prefix + 'jq');
       break;
     }
@@ -1298,7 +1301,7 @@ function startingTag(element) {
     // turns out IE does not let you set .html() on elements which
     // are not allowed to have children. So we just ignore it.
     element.empty();
-  } catch (e) {}
+  } catch (e) { /* empty */ }
   var elemHtml = jqLite('<div>').append(element).html();
   try {
     return element[0].nodeType === NODE_TYPE_TEXT ? lowercase(elemHtml) :

src/apis.js

@@ -74,7 +74,7 @@ HashMap.prototype = {
   }
 };
 
-var $$HashMapProvider = [function() {
+var $$HashMapProvider = [/* @this */function() {
   this.$get = [function() {
     return HashMap;
   }];