Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit d4ae798

Browse files
committed
chore(parseInt): cleanup parseInt() for our int()
1 parent 5ac14f6 commit d4ae798

File tree

6 files changed

+10
-9
lines changed

6 files changed

+10
-9
lines changed

src/Angular.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ var $boolean = 'boolean',
6161
$undefined = 'undefined',
6262
Error = window.Error,
6363
/** holds major version number for IE or NaN for real browsers */
64-
msie = parseInt((/msie (\d+)/.exec(lowercase(navigator.userAgent)) || [])[1], 10),
64+
msie = int((/msie (\d+)/.exec(lowercase(navigator.userAgent)) || [])[1]),
6565
jqLite, // delay binding since jQuery could be loaded after us.
6666
jQuery, // delay binding
6767
slice = [].slice,
@@ -205,6 +205,10 @@ function extend(dst) {
205205
return dst;
206206
}
207207

208+
function int(str) {
209+
return parseInt(str, 10);
210+
}
211+
208212

209213
function inherit(parent, extra) {
210214
return extend(new (extend(function() {}, {prototype:parent}))(), extra);

src/JSON.js

-3
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,6 @@ function jsonStringToDate(string){
7474
return date;
7575
}
7676
return string;
77-
function int(str) {
78-
return parseInt(str, 10);
79-
}
8077
}
8178

8279
function jsonDateToString(date){

src/directive/input.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ function textInputType(scope, element, attr, ctrl) {
415415

416416
// min length validator
417417
if (attr.ngMinlength) {
418-
var minlength = parseInt(attr.ngMinlength, 10);
418+
var minlength = int(attr.ngMinlength);
419419
var minLengthValidator = function(value) {
420420
if (!isEmpty(value) && value.length < minlength) {
421421
ctrl.$setValidity('minlength', false);
@@ -432,7 +432,7 @@ function textInputType(scope, element, attr, ctrl) {
432432

433433
// max length validator
434434
if (attr.ngMaxlength) {
435-
var maxlength = parseInt(attr.ngMaxlength, 10);
435+
var maxlength = int(attr.ngMaxlength);
436436
var maxLengthValidator = function(value) {
437437
if (!isEmpty(value) && value.length > maxlength) {
438438
ctrl.$setValidity('maxlength', false);

src/service/filter/filters.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ function dateFilter($locale) {
326326
format = $locale.DATETIME_FORMATS[format] || format;
327327
if (isString(date)) {
328328
if (NUMBER_STRING.test(date)) {
329-
date = parseInt(date, 10);
329+
date = int(date);
330330
} else {
331331
date = jsonStringToDate(date);
332332
}

src/service/filter/limitTo.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
function limitToFilter(){
5757
return function(array, limit) {
5858
if (!(array instanceof Array)) return array;
59-
limit = parseInt(limit, 10);
59+
limit = int(limit);
6060
var out = [],
6161
i, n;
6262

src/service/location.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ function matchUrl(url, obj) {
3030
match = {
3131
protocol: match[1],
3232
host: match[3],
33-
port: parseInt(match[5], 10) || DEFAULT_PORTS[match[1]] || null,
33+
port: int(match[5]) || DEFAULT_PORTS[match[1]] || null,
3434
path: match[6] || '/',
3535
search: match[8],
3636
hash: match[10]

0 commit comments

Comments
 (0)