perf($q): reduce closures when resolving promises

- changes Deferred.$$resolve to only wrap the internal resolve/reject when wrapping another promise

Author: jbedard

src/ng/q.js

@@ -243,18 +243,6 @@ function $$QProvider() {
  */
 function qFactory(nextTick, exceptionHandler) {
   var $qMinErr = minErr('$q', TypeError);
-  function callOnce(self, resolveFn, rejectFn) {
-    var called = false;
-    function wrap(fn) {
-      return function(value) {
-        if (called) return;
-        called = true;
-        fn.call(self, value);
-      };
-    }
-
-    return [wrap(resolveFn), wrap(rejectFn)];
-  }
 
   /**
    * @ngdoc method
@@ -361,21 +349,26 @@ function qFactory(nextTick, exceptionHandler) {
     },
 
     $$resolve: function(val) {
-      var then, fns;
+      if (this.promise.$$state.status > 0) return;
 
-      fns = callOnce(this, this.$$resolve, this.$$reject);
+      if (isPromiseLike(val)) {
+        this.promise.$$state.status = -1;
+        this.$$delayResolve(val);
+      } else {
+        this.promise.$$state.value = val;
+        this.promise.$$state.status = 1;
+        scheduleProcessQueue(this.promise.$$state);
+      }
+    },
+
+    $$delayResolve: function(promiseLike) {
+      var that = this;
+      function resolve(val) { that.$$resolve(val); }
+      function reject(val) { that.$$reject(val); }
       try {
-        if ((isObject(val) || isFunction(val))) then = val && val.then;
-        if (isFunction(then)) {
-          this.promise.$$state.status = -1;
-          then.call(val, fns[0], fns[1], this.notify);
-        } else {
-          this.promise.$$state.value = val;
-          this.promise.$$state.status = 1;
-          scheduleProcessQueue(this.promise.$$state);
-        }
+        promiseLike.then(resolve, reject, this.notify);
       } catch (e) {
-        fns[1](e);
+        reject(e);
         exceptionHandler(e);
       }
     },
@@ -386,6 +379,7 @@ function qFactory(nextTick, exceptionHandler) {
     },
 
     $$reject: function(reason) {
+      if (this.promise.$$state.status > 0) return;
       this.promise.$$state.value = reason;
       this.promise.$$state.status = 2;
       scheduleProcessQueue(this.promise.$$state);