Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit abafb21

Browse files
committed
perf(select): don't prepend unknown option if already prepended
1 parent 0ee432c commit abafb21

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/ng/directive/select.js

+8
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,12 @@ var SelectController =
4747
$element.val(unknownVal);
4848
};
4949

50+
self.updateUnknownOption = function(val) {
51+
var unknownVal = '? ' + hashKey(val) + ' ?';
52+
self.unknownOption.val(unknownVal);
53+
$element.val(unknownVal);
54+
}
55+
5056
$scope.$on('$destroy', function() {
5157
// disable unknown option so that we don't do work when the whole select is being destroyed
5258
self.renderUnknownOption = noop;
@@ -89,6 +95,8 @@ var SelectController =
8995
if (value == null && self.emptyOption) {
9096
self.removeUnknownOption();
9197
$element.val('');
98+
} else if (self.unknownOption.parent().length) {
99+
self.updateUnknownOption(value);
92100
} else {
93101
self.renderUnknownOption(value);
94102
}

0 commit comments

Comments
 (0)